Launchpad itself

Merge lp:~stevenk/launchpad/ajax-oops-link into lp:launchpad

  1. ajax-oops-link
  2. Merge into devel
Proposed by Steve Kowalik on 2012-09-20
Status: Merged
Approved by: Steve Kowalik on 2012-09-21
Approved revision: no longer in the source branch.
Merged at revision: 15995
Proposed branch: lp:~stevenk/launchpad/ajax-oops-link
Merge into: lp:launchpad
Diff against target: 21 lines (+2/-2)
1 file modified
lib/lp/app/javascript/ajax_log.js (+2/-2)
To merge this branch: bzr merge lp:~stevenk/launchpad/ajax-oops-link
Reviewer Review Type Date Requested Status
Ian Booth (community) 2012-09-20 Approve on 2012-09-20
Review via email: mp+125609@code.launchpad.net

Commit Message

Change the URL calculated for OOPS in the ajax log to oops.canonical.com.

Description of the Change

Change the URL calculated for OOPS in the ajax log. I'd prefer if this was backed off the config set in schema-lazr.conf, but it will do for now.

To post a comment you must log in.
Ian Booth (wallyworld) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/app/javascript/ajax_log.js'
2--- lib/lp/app/javascript/ajax_log.js 2012-02-13 20:50:09 +0000
3+++ lib/lp/app/javascript/ajax_log.js 2012-09-20 23:55:27 +0000
4@@ -53,6 +53,7 @@
5 */
6 Y.all('#ajax-time-list li.no-events').remove();
7 if (ajax_request_times[transactionid]) {
8+ var oops_url = 'https://oops.canonical.com/oops/?oopsid=';
9 var start_time = ajax_request_times[transactionid];
10 /* The time take for the AJAX event, in seconds.
11 */
12@@ -76,8 +77,7 @@
13 var oops = response.getResponseHeader('X-Lazr-OopsId');
14 if (oops) {
15 var oops_node = Y.Node.create('<a/>');
16- oops_node.setAttribute(
17- 'href', 'http://pad.lv/' + oops);
18+ oops_node.setAttribute('href', oops_url + oops);
19 oops_node.set('text', oops);
20 log_node.one('span').append(', OOPS ID:&nbsp;');
21 log_node.one('span').append(oops_node);