Merge lp:~steveire/unity8/update-cmake-requirement into lp:unity8

Proposed by Steveire
Status: Work in progress
Proposed branch: lp:~steveire/unity8/update-cmake-requirement
Merge into: lp:unity8
Diff against target: 9 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~steveire/unity8/update-cmake-requirement
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Needs Fixing
Review via email: mp+297953@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

It's not Ubuntu 16.04 that matters but vivid+overlay since we're still building against it, we have 3.0.2 there (we could backport it if really needed)

Revision history for this message
Albert Astals Cid (aacid) wrote :

Please set https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8 as description and a proper commit message.

review: Needs Fixing
Revision history for this message
Albert Astals Cid (aacid) wrote :

You'll also have to sign the CLA at http://www.ubuntu.com/legal/contributors before we can accept your merges.

Revision history for this message
Albert Astals Cid (aacid) wrote :

More than a month waiting for followup, will put it to WiP to clear my "to review" queue

Unmerged revisions

2491. By Steveire

Update the minimum cmake version to 3.0

The build depends on the CMAKE_AUTORCC feature which was first introduced in
CMake 3.0. Given that Ubuntu 16.04 ships with CMake 3.5, the minimum version
could be raised yet higher to take advantage of more features such as
transitive usage requirements.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-06-03 14:26:05 +0000
3+++ CMakeLists.txt 2016-06-20 20:25:57 +0000
4@@ -1,4 +1,4 @@
5-cmake_minimum_required(VERSION 2.8.9)
6+cmake_minimum_required(VERSION 3.0)
7
8 # Default install location. Must be set here, before setting the project.
9 if (NOT DEFINED CMAKE_INSTALL_PREFIX)

Subscribers

People subscribed via source and target branches