Linaro ChromiumOS

Merge lp:~steve-mcintyre/linaro-chromiumos/use-board-type into lp:linaro-chromiumos

  1. use-board-type
  2. Merge into trunk
Proposed by Steve McIntyre
Status: Merged
Merged at revision: 16
Proposed branch: lp:~steve-mcintyre/linaro-chromiumos/use-board-type
Merge into: lp:linaro-chromiumos
Diff against target: 10 lines (+1/-0)
1 file modified
remote/setup_build (+1/-0)
To merge this branch: bzr merge lp:~steve-mcintyre/linaro-chromiumos/use-board-type
Reviewer Review Type Date Requested Status
Loïc Minier (community) Approve
Review via email: mp+54682@code.launchpad.net

Description of the change

It helps if we actually pass the board type down to the build script...

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

LGTM

SCNR :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'remote/setup_build'
2--- remote/setup_build 2011-03-23 17:17:05 +0000
3+++ remote/setup_build 2011-03-24 11:49:41 +0000
4@@ -136,6 +136,7 @@
5 cmdline = './src/scripts/enter_chroot.sh -- ./%s' % options['build-script']
6 if options['nousepkg']:
7 cmdline += ' --nousepkg=True'
8+ cmdline += ' --board-type=%s' % options['board-type']
9 cmdline += ' --logdir=/var/log/saved-logs'
10 logged_run('logs/cros-build.log', cmdline)
11

Subscribers

People subscribed via source and target branches