Merge lp:~stevanr/linaro-license-protection/bug1085007 into lp:~linaro-automation/linaro-license-protection/trunk

Proposed by Stevan Radaković
Status: Merged
Merged at revision: 164
Proposed branch: lp:~stevanr/linaro-license-protection/bug1085007
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 59 lines (+18/-20)
2 files modified
templates/header.html (+9/-10)
templates_releases/header.html (+9/-10)
To merge this branch: bzr merge lp:~stevanr/linaro-license-protection/bug1085007
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Linaro Infrastructure Pending
Review via email: mp+149764@code.launchpad.net

Description of the change

Removed stale css file.
Introduced protocol-relative links for www.linaro.org.
Changed js/css scripts to hostless absolute paths.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good. I didn't known about protocol-relative URLs, found confirmation here: http://stackoverflow.com/questions/4978235/absolute-urls-omitting-the-protocol-scheme-in-order-to-preserve-the-one-of-the . That probably won't solve all issues we have (we have wrong SSL certificate for www.linaro.org), but at least it should resolve biggest probs.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/header.html'
2--- templates/header.html 2012-11-27 15:48:02 +0000
3+++ templates/header.html 2013-02-21 08:51:20 +0000
4@@ -5,16 +5,15 @@
5 {% endif %}
6 <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
7 <title>Linaro Snapshots</title>
8- <link rel="stylesheet" type="text/css" href="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/resources/css/ext-all.css" />
9- <link href="http://www.linaro.org/remote/css/init.css" rel="stylesheet" type="text/css" >
10- <link href="http://www.linaro.org/remote/css/remote.css" rel="stylesheet" type="text/css" >
11- <script language="javascript" type="text/javascript" src="http://www.linaro.org/remote/js/linarofamily.js"></script>
12-
13-
14- <script type="text/javascript" src="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/js/jquery-1.7.2.js"></script>
15- <script type="text/javascript" src="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/js/jquery-ui-1.8.23.custom.min.js"></script>
16- <link rel="stylesheet" type="text/css" href="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/css/jquery-ui/jquery-ui-1.8.23.custom.css" />
17- <link rel="stylesheet" type="text/css" href="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/css/linaro.css" />
18+ <link href="//www.linaro.org/remote/css/init.css" rel="stylesheet" type="text/css" >
19+ <link href="//www.linaro.org/remote/css/remote.css" rel="stylesheet" type="text/css" >
20+ <script language="javascript" type="text/javascript" src="//www.linaro.org/remote/js/linarofamily.js"></script>
21+
22+
23+ <script type="text/javascript" src="/js/jquery-1.7.2.js"></script>
24+ <script type="text/javascript" src="/js/jquery-ui-1.8.23.custom.min.js"></script>
25+ <link rel="stylesheet" type="text/css" href="/css/jquery-ui/jquery-ui-1.8.23.custom.css" />
26+ <link rel="stylesheet" type="text/css" href="/css/linaro.css" />
27
28
29 <style>
30
31=== modified file 'templates_releases/header.html'
32--- templates_releases/header.html 2012-10-18 09:19:50 +0000
33+++ templates_releases/header.html 2013-02-21 08:51:20 +0000
34@@ -5,16 +5,15 @@
35 {% endif %}
36 <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
37 <title>Linaro Releases</title>
38- <link rel="stylesheet" type="text/css" href="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/resources/css/ext-all.css" />
39- <link href="http://www.linaro.org/remote/css/init.css" rel="stylesheet" type="text/css" >
40- <link href="http://www.linaro.org/remote/css/remote.css" rel="stylesheet" type="text/css" >
41- <script language="javascript" type="text/javascript" src="http://www.linaro.org/remote/js/linarofamily.js"></script>
42-
43-
44- <script type="text/javascript" src="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/js/jquery-1.7.2.js"></script>
45- <script type="text/javascript" src="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/js/jquery-ui-1.8.23.custom.min.js"></script>
46- <link rel="stylesheet" type="text/css" href="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/css/jquery-ui/jquery-ui-1.8.23.custom.css" />
47- <link rel="stylesheet" type="text/css" href="{% if request.is_secure %}https{% else %}http{% endif %}://{{ request.get_host }}/css/linaro.css" />
48+ <link href="//www.linaro.org/remote/css/init.css" rel="stylesheet" type="text/css" >
49+ <link href="//www.linaro.org/remote/css/remote.css" rel="stylesheet" type="text/css" >
50+ <script language="javascript" type="text/javascript" src="//www.linaro.org/remote/js/linarofamily.js"></script>
51+
52+
53+ <script type="text/javascript" src="/js/jquery-1.7.2.js"></script>
54+ <script type="text/javascript" src="/js/jquery-ui-1.8.23.custom.min.js"></script>
55+ <link rel="stylesheet" type="text/css" href="/css/jquery-ui/jquery-ui-1.8.23.custom.css" />
56+ <link rel="stylesheet" type="text/css" href="/css/linaro.css" />
57
58
59 <style>

Subscribers

People subscribed via source and target branches