Merge lp:~stevanr/linaro-android-build-tools/drop-eula-generation into lp:linaro-android-build-tools

Proposed by Stevan Radaković
Status: Merged
Approved by: Georgy Redkozubov
Approved revision: 600
Merged at revision: 598
Proposed branch: lp:~stevanr/linaro-android-build-tools/drop-eula-generation
Merge into: lp:linaro-android-build-tools
Diff against target: 83 lines (+12/-21)
6 files modified
build-scripts/BUILD-INFO_toolchain.txt (+7/-0)
build-scripts/build-android (+0/-13)
build-scripts/build-android-toolchain (+2/-2)
build-scripts/build-android-toolchain-linaro (+2/-2)
utils/mangle-jobs/builders.xml (+1/-1)
utils/mangle-jobs/push-artifacts-set.mangle (+0/-3)
To merge this branch: bzr merge lp:~stevanr/linaro-android-build-tools/drop-eula-generation
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Review via email: mp+160053@code.launchpad.net

Description of the change

Remove EULA/OPEN-EULA support.

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Stevan, there will be problem with toolchain builds because they don't have build-info.txt support, i.e. toolchain build doesn't generate BUILD-INFO.txt.
I guess we need to add 'open' BUILD-INFO.txt to build script directory and just copy it to the artifacts location.

599. By Stevan Radaković

Add open BUILD-INFO for toolchain builds.

Revision history for this message
Georgy Redkozubov (gesha) wrote :

I think it's better to say:
# Add BUILD-INFO.txt support
instead of
# Add open BUILD-INFO to replace OPEN-EULA

And copy BUILD-INFO_toolchain.txt to ../out/BUILD-INFO.txt

review: Needs Fixing
600. By Stevan Radaković

Fix dumb errors.

Revision history for this message
Georgy Redkozubov (gesha) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'build-scripts/BUILD-INFO_toolchain.txt'
2--- build-scripts/BUILD-INFO_toolchain.txt 1970-01-01 00:00:00 +0000
3+++ build-scripts/BUILD-INFO_toolchain.txt 2013-04-22 11:42:27 +0000
4@@ -0,0 +1,7 @@
5+Format-Version: 0.1
6+
7+
8+Files-Pattern: *
9+Build-Name: toolchain
10+License-Type: open
11+
12
13=== modified file 'build-scripts/build-android'
14--- build-scripts/build-android 2013-01-25 11:31:16 +0000
15+++ build-scripts/build-android 2013-04-22 11:42:27 +0000
16@@ -160,16 +160,3 @@
17 if [ -f out/kernel_config ]; then
18 (cd out/; ${BUILD_SCRIPT_ROOT}/create-user-kernel-script)
19 fi
20-
21-# add EULA support
22-(
23- if [[ "$JOB_NAME" =~ .*blob.* && ("$JOB_NAME" =~ .*origen.* || "$JOB_NAME" =~ .*snowball.*) ]]
24- then
25- eula="EULA.txt"
26- else
27- eula="OPEN-EULA.txt"
28- fi
29- touch out/OPEN-EULA.txt
30- cd out/target/product/*/
31- touch $eula
32-) || true
33
34=== modified file 'build-scripts/build-android-toolchain'
35--- build-scripts/build-android-toolchain 2012-08-02 10:26:24 +0000
36+++ build-scripts/build-android-toolchain 2013-04-22 11:42:27 +0000
37@@ -65,5 +65,5 @@
38 $MAKE $MAKE_OPTS install prefix=$PWD/../out/cross/$TOOLCHAIN_PREFIX
39 tar -cj -C ../out/cross -f ../out/android-toolchain-eabi-$GCC_VERSION-$BUILD_NUMBER-$BUILD_ID-linux-x64.tar.bz2 .
40
41-# add EULA support
42-touch ../out/OPEN-EULA.txt
43+# Add BUILD-INFO.txt support
44+cp ${BUILD_SCRIPT_ROOT}/BUILD-INFO_toolchain.txt ../out/BUILD-INFO.txt
45
46=== modified file 'build-scripts/build-android-toolchain-linaro'
47--- build-scripts/build-android-toolchain-linaro 2012-08-02 10:26:24 +0000
48+++ build-scripts/build-android-toolchain-linaro 2013-04-22 11:42:27 +0000
49@@ -113,5 +113,5 @@
50 $i -v
51 done
52
53-# add EULA suport
54-touch ../out/OPEN-EULA.txt
55+# Add BUILD-INFO.txt support
56+cp ${BUILD_SCRIPT_ROOT}/BUILD-INFO_toolchain.txt ../out/BUILD-INFO.txt
57
58=== modified file 'utils/mangle-jobs/builders.xml'
59--- utils/mangle-jobs/builders.xml 2013-04-18 13:01:57 +0000
60+++ utils/mangle-jobs/builders.xml 2013-04-22 11:42:27 +0000
61@@ -5,7 +5,7 @@
62 bzr get lp:linaro-android-build-tools build-tools
63 sudo -H -E build-tools/node/build us-east-1.ec2-git-mirror.linaro.org "$CONFIG"
64
65-time build-tools/utils/new-publish/publish -p2 $JOB_NAME/$BUILD_NUMBER "build/out/target/*/*/*.img,build/out/target/*/*/*.img.bz2,build/out/target/*/*/*.tar.bz2,build/out/target/*/*/MD5SUMS,build/out/*.tar.bz2,build/out/*.xml,build/out/*_config,build/out/lava-job-info,build/out/linaro_kernel_build_cmds.sh,build/out/linaro_android_build_cmds.sh,build/out/*EULA*,build/out/target/product/*/*EULA*,build/out/target/product/*/howto/*EULA*,build/out/BUILD-INFO.txt,build/out/*/BUILD-INFO.txt,build/out/*/*/BUILD-INFO.txt,build/out/*/*/*/BUILD-INFO.txt,build/out/target/product/*/howto/HOWTO_*.txt,build/out/target/product/*/HOWTO_*.txt"
66+time build-tools/utils/new-publish/publish -p2 $JOB_NAME/$BUILD_NUMBER "build/out/target/*/*/*.img,build/out/target/*/*/*.img.bz2,build/out/target/*/*/*.tar.bz2,build/out/target/*/*/MD5SUMS,build/out/*.tar.bz2,build/out/*.xml,build/out/*_config,build/out/lava-job-info,build/out/linaro_kernel_build_cmds.sh,build/out/linaro_android_build_cmds.sh,build/out/BUILD-INFO.txt,build/out/*/BUILD-INFO.txt,build/out/*/*/BUILD-INFO.txt,build/out/*/*/*/BUILD-INFO.txt,build/out/target/product/*/howto/HOWTO_*.txt,build/out/target/product/*/HOWTO_*.txt"
67
68 build-tools/node/lava-submit "$CONFIG"
69
70
71=== modified file 'utils/mangle-jobs/push-artifacts-set.mangle'
72--- utils/mangle-jobs/push-artifacts-set.mangle 2013-04-17 16:53:28 +0000
73+++ utils/mangle-jobs/push-artifacts-set.mangle 2013-04-22 11:42:27 +0000
74@@ -10,9 +10,6 @@
75 "build/out/lava-job-info," \
76 "build/out/linaro_kernel_build_cmds.sh," \
77 "build/out/linaro_android_build_cmds.sh," \
78- "build/out/*EULA*," \
79- "build/out/target/product/*/*EULA*," \
80- "build/out/target/product/*/howto/*EULA*," \
81 "build/out/**/BUILD-INFO.txt," \
82 "build/out/target/product/*/HOWTO_*.txt" \
83 "build/out/target/product/*/howto/HOWTO_*.txt"

Subscribers

People subscribed via source and target branches