Merge lp:~stevanr/lava-dashboard/fix-1198190 into lp:lava-dashboard

Proposed by Stevan Radaković
Status: Merged
Approved by: Senthil Kumaran S
Approved revision: 414
Merged at revision: 413
Proposed branch: lp:~stevanr/lava-dashboard/fix-1198190
Merge into: lp:lava-dashboard
Diff against target: 24 lines (+3/-3)
1 file modified
dashboard_app/static/dashboard_app/js/image-report.js (+3/-3)
To merge this branch: bzr merge lp:~stevanr/lava-dashboard/fix-1198190
Reviewer Review Type Date Requested Status
Senthil Kumaran S Approve
Antonio Terceiro Pending
Review via email: mp+176942@code.launchpad.net

Description of the change

To post a comment you must log in.
414. By Stevan Radaković

Scratch the global variable problem.

Revision history for this message
Senthil Kumaran S (stylesen) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dashboard_app/static/dashboard_app/js/image-report.js'
2--- dashboard_app/static/dashboard_app/js/image-report.js 2013-07-03 14:48:22 +0000
3+++ dashboard_app/static/dashboard_app/js/image-report.js 2013-07-25 13:59:25 +0000
4@@ -104,9 +104,9 @@
5 // Create column headlines.
6 result_table_head = "<tr>";
7 for (iter in column_data) {
8- build_number = column_data[iter]["number"].split('.')[0];
9+ if (test_build_number(column_data, iter)) {
10
11- if (test_build_number(column_data, iter)) {
12+ build_number = column_data[iter]["number"].split('.')[0];
13 if (!isNumeric(build_number)) {
14 build_number = format_date(build_number.split(' ')[0]);
15 }
16@@ -381,7 +381,7 @@
17 function test_build_number(column_data, iter) {
18 // Test if the build number/date is between specified number/date boundaries.
19
20- build_number = column_data[iter]["date"];
21+ var build_number = column_data[iter]["date"];
22
23 if (build_number <= $("#build_number_end").val() && build_number >= $("#build_number_start").val()) {
24 return true;

Subscribers

People subscribed via source and target branches