Merge lp:~stephen-stewart/ulysses/no-more-csslint into lp:ulysses

Proposed by Stephen Stewart on 2014-12-08
Status: Merged
Approved by: James Westby on 2014-12-08
Approved revision: 52
Merged at revision: 52
Proposed branch: lp:~stephen-stewart/ulysses/no-more-csslint
Merge into: lp:ulysses
Diff against target: 50 lines (+0/-18)
3 files modified
.csslintrc (+0/-14)
gulpfile.js (+0/-3)
package.json (+0/-1)
To merge this branch: bzr merge lp:~stephen-stewart/ulysses/no-more-csslint
Reviewer Review Type Date Requested Status
James Westby (community) 2014-12-08 Approve on 2014-12-08
Review via email: mp+244003@code.launchpad.net

Commit message

After a long trial I find CSSLint to be not very useful at all and in fact somewhat of a hindrance.

Description of the change

After a long trial I find CSSLint to be not very useful at all and in fact somewhat of a hindrance.

To post a comment you must log in.
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file '.csslintrc'
2--- .csslintrc 2014-09-23 16:05:04 +0000
3+++ .csslintrc 1970-01-01 00:00:00 +0000
4@@ -1,14 +0,0 @@
5-{
6- "adjoining-classes": false,
7- "box-model": false,
8- "box-sizing": false,
9- "compatible-vendor-prefixes": false,
10- "fallback-colors" : false,
11- "qualified-headings": false,
12- "regex-selectors": false,
13- "star-property-hack": false,
14- "unique-headings": false,
15- "universal-selector": false,
16- "unqualified-attributes": false,
17- "zero-units": false
18-}
19
20=== modified file 'gulpfile.js'
21--- gulpfile.js 2014-10-09 14:35:24 +0000
22+++ gulpfile.js 2014-12-08 15:21:16 +0000
23@@ -1,6 +1,5 @@
24 var autoprefixer = require('gulp-autoprefixer');
25 var concat = require('gulp-concat');
26-var csslint = require('gulp-csslint');
27 var csso = require('gulp-csso');
28 var del = require('del');
29 var fs = require('fs');
30@@ -36,8 +35,6 @@
31 gulp.task('build', function() {
32 var filter = gulpFilter(['*.css', '!*-small.css']);
33 return gulp.src(paths.css)
34- .pipe(csslint('.csslintrc'))
35- .pipe(csslint.reporter())
36 .pipe(autoprefixer())
37 .pipe(csso())
38 .pipe(gulp.dest(paths.dest))
39
40=== modified file 'package.json'
41--- package.json 2014-10-07 10:47:28 +0000
42+++ package.json 2014-12-08 15:21:16 +0000
43@@ -17,7 +17,6 @@
44 "gulp": "^3.8.8",
45 "gulp-autoprefixer": "^1.0.1",
46 "gulp-concat": "^2.4.1",
47- "gulp-csslint": "^0.1.5",
48 "gulp-csso": "^0.2.9",
49 "gulp-filter": "^1.0.2",
50 "gulp-ignore": "^1.2.0",

Subscribers

People subscribed via source and target branches