Merge lp:~stephen-stewart/ulysses/fix-csslint-errors into lp:ulysses

Proposed by Stephen Stewart
Status: Merged
Merged at revision: 18
Proposed branch: lp:~stephen-stewart/ulysses/fix-csslint-errors
Merge into: lp:ulysses
Diff against target: 120 lines (+7/-43)
3 files modified
.csslintrc (+2/-17)
src/layout.css (+0/-8)
src/navigation.css (+5/-18)
To merge this branch: bzr merge lp:~stephen-stewart/ulysses/fix-csslint-errors
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
Review via email: mp+200681@code.launchpad.net

Commit message

fix css lint errors, silence errors that shouldn't be fixed

Description of the change

fix css lint errors, silence errors that shouldn't be fixed

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.csslintrc'
2--- .csslintrc 2014-01-07 11:56:26 +0000
3+++ .csslintrc 2014-01-07 15:30:53 +0000
4@@ -2,26 +2,11 @@
5 "adjoining-classes": false,
6 "box-model": false,
7 "box-sizing": false,
8- "bulletproof-font-face": false,
9- "display-property-grouping": false,
10- "duplicate-background-images": false,
11- "empty-rules": false,
12- "fallback-colors": false,
13- "floats": false,
14- "font-faces": false,
15- "font-sizes": false,
16- "gradients": false,
17- "import": false,
18- "non-link-hover": false,
19- "outline-none": false,
20- "overqualified-elements": false,
21+ "fallback-colors" : false,
22 "qualified-headings": false,
23- "regex-selectors": false,
24- "shorthand": false,
25- "text-indent": false,
26 "unique-headings": false,
27 "universal-selector": false,
28 "unqualified-attributes": false,
29- "vendor-prefix": false,
30+ "regex-selectors": false,
31 "zero-units": false
32 }
33
34=== modified file 'src/layout.css'
35--- src/layout.css 2014-01-07 11:56:26 +0000
36+++ src/layout.css 2014-01-07 15:30:53 +0000
37@@ -30,14 +30,6 @@
38 }
39
40 /**
41- * Banner
42- */
43-
44-.ues-banner {
45-}
46-
47-
48-/**
49 * Footer
50 */
51
52
53=== modified file 'src/navigation.css'
54--- src/navigation.css 2014-01-07 11:56:26 +0000
55+++ src/navigation.css 2014-01-07 15:30:53 +0000
56@@ -157,6 +157,7 @@
57 .ues-navbar-brand a {
58 display:inline-block;
59 text-indent:-9000px;
60+ direction: ltr;
61 }
62
63 /**
64@@ -177,7 +178,6 @@
65 .ues-navbar-text {
66 display:inline-block;
67 margin:0;
68- float:left;
69 }
70 .ues-navbar-text a {
71 border-bottom: 1px solid white;
72@@ -241,36 +241,24 @@
73 right:0;
74 }
75
76-.ues-navbar .ues-menu li a {
77-}
78-
79-.ues-navbar .ues-menu li:last-child a {
80-}
81-
82-
83 .ues-navbar .ues-menu li a:hover {
84 background-color:#f75216;
85 }
86
87-/*csslint important: false*/
88 .ues-menu.user li a {
89 width:40px;
90 text-indent:-9000px;
91+ direction: ltr;
92 background: transparent url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAJ4AAAAfCAYAAAAWaXQGAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAACStJREFUeNrsnAtQFPcdx/97txx3HKcCBlDkFZ+TWKtJa50oTGy1ySTVPMY+NLXTJlO0yUzHRx8JaQbTkEfHKZm2aWtqmnaaJk6MYRKhbZwSsYazdAoDiFER0OP9EDjhOO84uLv+fsv/yHLZ3ds9dpeGud/Mj//u/l+f++/3/q9djiFhFgwGF0HwOfCl4DngS8BTwdPB54HPpy5kw9RHwHvB+8E7wR3greCNDMP0hNVH5Bjki3HOIU6GV3E2BL8DvxsTgl+l3kkL6+UV7gYfh8LcNK8VgjhwKw8ynTp+gFvpB1oNfgb8ccjbFk1DxTjnBmeo8lzwPvAS8ESikWHZtA6sKzfUUHI8xjm3OEMRp8B/SXQyrAvrjKKhYpxzhBNPFoN7tVS8yDfAS+uW21gxzjnEaYDz28GbYOwd5SeqzJt0GYUxUvFCZdC6mmjdck2QU0uLcWrHycKfFeAtUSr4eQgSwPdHkb2F1v1Pmemj5pyhqcop58ssZZs/mhvticLLlQsAQjsGwTug3FI8r/5GroUxGi28+C0QrIP4wzIBchUAT+Oc6Q1UcGNnxKnE7j4bxF6onJ7efyafuajwhurCqYLwclm67K2Sk6PhwNakCZfTFjr39jqKITBS0RmdtR8+1H/6bbkAHeAbFQDL5lTZdOP0DfYUmVIW5dDjZyH4+v8jpxrticJbTPdqIpqzpuIpCNpDQoNgAe7rwBopAy4cM6dlLewpO/p9mQBYZ4YCYEFO6CW4Pgp6hzze+aYoGqQqVIYWnHJswH4ye/H2PfS4LFthdlU4PReqVVWZZfUGQU4U3i1SDQUC+zEEdhg+z8EwVAfnZhAazu32gifzZo7E1VTbDmnsNN86CH4CN3OnSNF9tG65Jsg52ly3hrcPzp0nLl+nuIFGm+vXaMkpx1pfOXDypuPSejzuKT96UmF21Tk99WdR/E+C30cmN4Ux/d/BX6JJBOMsa/PbInGi8HC3eVh0QH7lwHJ3S8MFKiZzMOA/xRiM+UJpbau+YMI0IFJv45Pb5pvTspdIANwg4o9ghEyQs+axO84TnvLoeTQ9XqOWnCJzujQI/sr7ljOe7qtX8DDn0UP2qvuSlPCrygmiuxd4TkCHYuVdzsIOx2hL+i6e+F1Oc3gc5NkNeXeA+D6Q4mTpcHlDDKDz+MvHIajD44DPW2QwmfNFu9WMZemB8bFD+E0YPFeON/LlCA21QEFDiXHmRTifqanF+SkbG+h+PH7h4i0325tcCVkrbThqWDKWksCYx8+wcWUgzE0wYtTrzQnCyQkGAu8yBkPCp7ZETGZiyrnNjF917+VaEvR5w/dMrJC3FMq4DcTnEOPEfTxclbokVnkV4IPQkxlAzfsirnz9/h/i/A/zgJdKJHXRumVPF6Q4NTTNOBkjW+C+2kiuHC7o4l+/+Nwj497eNkvQP3EaxPcqup6cE173C0KiQ2PTMmE5CdN7g5GwqZnCn8tgsEAZxVKcrMQwgMNXCcznXoCh8/rE6I0sNnGBOdKnMZoTLOPDA/hg+AoIEOeAB+Fb8LRWqtBhcaEV98qx/o7klt/sb7117y/eh0urpnrCvvbHGvZvKV794vuZ8SmLvkUv79GLDe73NtH7Oy952vG4eCkPSNVhEIuAm0D6K4/fdfUPhdxEo+/UG5lywXv+9jq3uup4u2ThUPU/tmrZSLiY4C8MJhcb0ZRTv4boaNi+/96R1ems/fA7MH3ZzI9b8aNXB7y9jvya732+0b49dQBdTzZDXLxVVE6s6ZPjOJN4B2QSL4PrOaVGzYtF36zAlT2eOP78877UrbtI3LwUSejxkUHScewwN3S0/vagE4JzWjaSDosLrQwfHS2dvJlsDhU/SVy+lpiS0/bR1eIdszC1IBOeURJnFV6nBCd8ILj4yeNxn3gZN6VnG4YIDE/DPG2IE9TwQGtP+R89EXs7SINp6fzwOgT7NG6nvDCh5VEhKvVNZJaMtc63wYKCXCrefQnmdSC89HtgKF40WzyjXS1usTj/yNAnx64h8TK6W92RhIdiskns4z0MngIi8re/+dKvh8+LPyzEuLa/FP8K02Ie+ghNzGy0brkmyamhac4ZN39h/I26M373tQsP9FccC8Kiw+Bz9h+cLc7rjVVlgfEx4Z6sr4OQgJ9z7ljAMC+WIcXJ8pbhgqV4Opv3+4b6UNpnJlzOZxsO3rMpe3fhxoyHniCsLWlqeO1+7wgBYdr9ntFD3NLlcs2XAj7Pg3BYMdNth7Dtgg6dFxeqcIYxF0FwaNpSr6nmYwiae8pfK0v76re3w7xvD6QrBCaf2ts4kTg9A12FbRVvPZi9ZZfFQIfVqY7I5yXeloapYyHRQV4PliHFydJNRNGNx//sWtEZ2miEnsxTmef5yrXXnvmZ4/WiJ+JvWZLEsHHE2+MYDAb8RyDJ85CG+6rUFnwR8zRHaKhhBQ0lyKnDkwtVOKfNSx9da4tPyyK2FXcS28pJHz5fdYJTQ8PZwsFz5dtTNm5L9Hvdj8ClPykQniqcG35f7aj+wYaHm94pOZG6drN1XtYqwibYuHnbSPtl0l9fyQ2jYnE+l3MHliHFicLDeVi6xD7eTt6wexeZfIfrmcq8QJG3rx2fTOA7946p4ZWQVRBfRx+d2SXeIkmjdcs1QU4dFheqcE4TeUtDCfi/Bu1ld8JpyN+g0R93lx+1g/A2wuhRqEB4qnKCcD4A8d3e+VHpU3Shg+Xj4y58LPYiphGLg7xtkThReN2RGmpqOLj8312GeMtpOCwFYQVAaDhPGAWh+bkuuqv1a0aLFYV6r4zisM4uBQ0lxqn1kwu1OMPToAvOg0CQP4Uhtiq0o6AnJ4iNf4oC2itRhmBcWBmCnCg8HEpl7dHVFqxHkJGpiaZ7+DnoBm/C4QFuWN65DNfQTpkfPFNhQ8nmVNlmg9PO78X15JR40VTV9kThXQP/spwcADXtBU/7/cmeYCDg4cXjI7JSmQDLwE8rAJ7GqUMDqcKpo32mOFF4+DZEgVgqqTd9QXTY0wWjfBsYAY4oSC/JqXFDqcap4Rfms9Wesf+KinHOBmfoQuz/QGOcunKGLsT+8z3GqSsn95IAwzDX4AK+co2/oYGRWv+Gxvppv6Eh02Kcc4eTEVBn7NeNYpyac/5PgAEAqD4AO5ib0uMAAAAASUVORK5CYII=) 4px 16px no-repeat;
93- border:none !important;
94 }
95
96-/*csslint important: true*/
97-/** ?use a icon font for this **/
98-.ues-menu.user li a.account {
99-}
100-.ues-menu.user li a.settings {
101+.ues-menu.user .settings {
102 background-position:-38px 16px;
103 }
104-.ues-menu.user li a.logout {
105+.ues-menu.user .logout {
106 background-position:-80px 16px;
107 }
108-.ues-menu.user li a.together {
109+.ues-menu.user .together {
110 background-position:-122px 16px;
111 }
112
113@@ -281,7 +269,6 @@
114 }
115
116 .ues-pagination li {
117- margin:0;
118 padding:0;
119 display:inline;
120 list-style:none;

Subscribers

People subscribed via source and target branches