Merge lp:~stephen-stewart/snapweb/json-responses into lp:~snappy-dev/snapweb/trunk

Proposed by Stephen Stewart on 2015-05-06
Status: Merged
Approved by: John Lenton on 2015-05-06
Approved revision: 115
Merged at revision: 118
Proposed branch: lp:~stephen-stewart/snapweb/json-responses
Merge into: lp:~snappy-dev/snapweb/trunk
Prerequisite: lp:~chipaca/snapweb/json-responses
Diff against target: 60 lines (+5/-11)
2 files modified
www/src/js/views/snap-layout.js (+1/-5)
www/tests/modelSpec.js (+4/-6)
To merge this branch: bzr merge lp:~stephen-stewart/snapweb/json-responses
Reviewer Review Type Date Requested Status
John Lenton 2015-05-06 Approve on 2015-05-06
Review via email: mp+258355@code.launchpad.net

This proposal supersedes a proposal from 2015-05-06.

Commit Message

Fix up js for now more correct content type from server.

Description of the Change

see ~chipaca/webdm/json-responses

To post a comment you must log in.
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'www/src/js/views/snap-layout.js'
2--- www/src/js/views/snap-layout.js 2015-05-05 15:06:52 +0000
3+++ www/src/js/views/snap-layout.js 2015-05-06 09:50:00 +0000
4@@ -134,15 +134,11 @@
5 this.model.set({
6 status: CONF.INSTALL_STATE.UNINSTALLING
7 });
8- this.model.destroy({
9- dataType : 'html'
10- });
11+ this.model.destroy();
12 } else if (status === CONF.INSTALL_STATE.UNINSTALLED) {
13 // install
14 this.model.save({
15 status: CONF.INSTALL_STATE.INSTALLING
16- }, {
17- dataType : 'html'
18 });
19 } else {
20 e.preventDefault();
21
22=== modified file 'www/tests/modelSpec.js'
23--- www/tests/modelSpec.js 2015-04-30 14:12:30 +0000
24+++ www/tests/modelSpec.js 2015-05-06 09:50:00 +0000
25@@ -94,15 +94,14 @@
26 });
27 model.save({
28 status: 'installing'
29- }, {
30- dataType: 'html'
31 });
32 expect(model.save).toHaveBeenCalled();
33 expect(model.fetch).not.toHaveBeenCalled();
34
35 jasmine.Ajax.requests.mostRecent().respondWith({
36 'status': 202,
37- 'contentType': 'plain/text'
38+ 'contentType': 'application/json',
39+ 'responseText': '{}'
40 });
41 });
42
43@@ -116,15 +115,14 @@
44 });
45 model.save({
46 status: 'installing'
47- }, {
48- dataType: 'html'
49 });
50 expect(model.save).toHaveBeenCalled();
51 expect(model.fetch).not.toHaveBeenCalled();
52
53 jasmine.Ajax.requests.mostRecent().respondWith({
54 'status': 200,
55- 'contentType': 'plain/text'
56+ 'contentType': 'application/json',
57+ 'responseText': '{}'
58 });
59 });
60 });

Subscribers

People subscribed via source and target branches