snapweb

Merge lp:~stephen-stewart/snapweb/destroy-without-removal into lp:~snappy-dev/snapweb/trunk

  1. destroy-without-removal
  2. Merge into trunk
Proposed by Stephen Stewart on 2015-05-07
Status: Merged
Approved by: Sergio Schvezov on 2015-05-07
Approved revision: 131
Merged at revision: 131
Proposed branch: lp:~stephen-stewart/snapweb/destroy-without-removal
Merge into: lp:~snappy-dev/snapweb/trunk
Diff against target: 21 lines (+3/-2)
1 file modified
www/src/js/behaviors/install.js (+3/-2)
To merge this branch: bzr merge lp:~stephen-stewart/snapweb/destroy-without-removal
Reviewer Review Type Date Requested Status
Sergio Schvezov 2015-05-07 Approve on 2015-05-07
Review via email: mp+258547@code.launchpad.net

Commit Message

silence the destroy events on model destroy

Description of the Change

this maybe isn't how we want to handle this long term, but works for now

To post a comment you must log in.
Sergio Schvezov (sergiusens) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'www/src/js/behaviors/install.js'
2--- www/src/js/behaviors/install.js 2015-05-07 15:38:47 +0000
3+++ www/src/js/behaviors/install.js 2015-05-07 19:43:00 +0000
4@@ -84,14 +84,15 @@
5 status: CONF.INSTALL_STATE.UNINSTALLING
6 });
7 model.destroy({
8- dataType : 'html'
9+ dataType : 'json',
10+ silent: true
11 });
12 } else if (status === CONF.INSTALL_STATE.UNINSTALLED) {
13 // install
14 model.save({
15 status: CONF.INSTALL_STATE.INSTALLING
16 }, {
17- dataType : 'html'
18+ dataType : 'json'
19 });
20 } else {
21 e.preventDefault();

Subscribers

People subscribed via source and target branches