Merge lp:~stephen-j-boddy/terminator/bugfix-lp-1089162 into lp:terminator/trunk

[Stephen Boddy]

Trivial fix for off-center splits. Line was not accounting for the size of the handle.

[Stephen Boddy (stephen-j-boddy)]

Hmm. I'm thinking about it now, and wondering if the function below (set_position) need changing to allow for handle size too. I think we are setting the ratio to the left/top point of the splitter. If the splitter is non-zero then the ratio will be slightly off.

[Chris Jones (cmsj)]

Stephen: Do you still want to get this applied? Or do you think it would be better to change more stuff in one go?

[Stephen Boddy (stephen-j-boddy)]

Chris: I've switched this to Work in progress. As well as the comment above, after submitting for merging I noticed some odd jumpiness in splitter behviour that I haven't had time to figure out and fix. I'll come back to it when I get the opportunity.

[Stephen Boddy (stephen-j-boddy)]

The patch below was not enough. Revision 1579 is the full fix, although there is still an issue with erratic behaviour when equalizing splits, it seems that was there before, and is an unrelated issue.

=== modified file 'terminatorlib/paned.py'
--- terminatorlib/paned.py	2012-10-19 16:57:23 +0000
+++ terminatorlib/paned.py	2012-12-13 17:11:26 +0000
@@ -386,7 +386,8 @@
             self.set_position(self.get_position())
     
     def set_position_by_ratio(self):
-        self.set_pos(int(self.ratio*self.get_length()))
+        handle_size = self.style_get_property('handle-size')
+        self.set_pos(int((self.ratio*self.get_length())-(handle_size/2.0)))
 
     def set_position(self, pos):
         self.ratio = float(pos) / self.get_length()