Merge lp:~stefanor/ubuntu-dev-tools/launchpadlib-1.9 into lp:~ubuntu-dev/ubuntu-dev-tools/trunk

Proposed by Stefano Rivera
Status: Merged
Merged at revision: 1032
Proposed branch: lp:~stefanor/ubuntu-dev-tools/launchpadlib-1.9
Merge into: lp:~ubuntu-dev/ubuntu-dev-tools/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~stefanor/ubuntu-dev-tools/launchpadlib-1.9
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+51475@code.launchpad.net

Description of the change

Not entirely sure what the best way out of this is.
I can upload this, which will stop it from using staging, but it won't be usable by ssh or any other method that leaves you without access to your credentials.

That seems better than nothing, right?

To post a comment you must log in.
Revision history for this message
Michael Bienia (geser) wrote :

As "get_launchpad()" is now only a wrapper around Launchpad.login_with() which doesn't do anything special, what about removing "get_launchpad()" altogether and directly using Launchpad.login_with()?

I've also looked what still left in ubuntutools.lp.libsupport and saw "approve_application". It doesn't seem to be used anywhere anymore (at least my grep didn't find any user). Can we drop it?

1036. By Stefano Rivera

* Remove ubuntutools.lp.libsupport.approve_application, no longer used.

1037. By Stefano Rivera

Use Launchpadlib.login_with() directly in scripts.

1038. By Stefano Rivera

* Remove ubuntutools.lp.libsupport.get_launchpad, no longer used.

1039. By Stefano Rivera

Skip pylint test if it crashes.

Revision history for this message
Stefano Rivera (stefanor) wrote :

Michael: done.

All the issues we've come across have been forwarded: https://bitbucket.org/kang/python-keyring-lib/issue/40/failures-happen-at-random-points-in-the

1040. By Stefano Rivera

Document Launchpadlib 1.9 issues in NEWS.

1041. By Stefano Rivera

Reformat NEWS

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: