launchpadlib

Merge lp:~stefanor/launchpadlib/version.txt into lp:launchpadlib

  1. version.txt
  2. Merge into trunk
Proposed by Stefano Rivera
Status: Merged
Merged at revision: 173
Proposed branch: lp:~stefanor/launchpadlib/version.txt
Merge into: lp:launchpadlib
Diff against target: 11 lines (+1/-0)
1 file modified
setup.py (+1/-0)
To merge this branch: bzr merge lp:~stefanor/launchpadlib/version.txt
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+376084@code.launchpad.net

Commit message

Explicitly install version.txt, launchpadlib requires it

Don't just rely on MANIFEST.in to include version.txt, as this isn't included in the sdist.

Description of the change

See also: https://bugs.launchpad.net/lazr.uri/+bug/918660

Alternatively MANIFEST.in should be in MANIFEST.in (I think)

To post a comment you must log in.
lp:~stefanor/launchpadlib/version.txt updated
173. By Stefano Rivera

Explicitly install version.txt, launchpadlib requires it

Don't just rely on MANIFEST.in to include version.txt, as this isn't included
in the sdist.

Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2019-11-07 17:40:56 +0000
3+++ setup.py 2019-11-27 19:41:01 +0000
4@@ -58,6 +58,7 @@
5 version=__version__,
6 packages=find_packages('src'),
7 package_dir={'':'src'},
8+ package_data={'launchpadlib': ['version.txt']},
9 include_package_data=True,
10 zip_safe=False,
11 author='The Launchpad developers',

Subscribers

People subscribed via source and target branches