launchpadlib

Merge lp:~stefanor/launchpadlib/include-manifest into lp:launchpadlib

  1. include-manifest
  2. Merge into trunk
Proposed by Stefano Rivera
Status: Merged
Merged at revision: 188
Proposed branch: lp:~stefanor/launchpadlib/include-manifest
Merge into: lp:launchpadlib
Diff against target: 9 lines (+1/-1)
1 file modified
MANIFEST.in (+1/-1)
To merge this branch: bzr merge lp:~stefanor/launchpadlib/include-manifest
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+410701@code.launchpad.net

Commit message

Don't exclude MANIFEST.in

Building from the sdist (as the Debian package does) misses the XML resources
for the tests, without the MANIFEST.in being present.

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

Whether including 1.5MiB of XML in the package is another question entirely. But then we should probably be dropping launchpadlib.testing and launchpadlib.tests rather than just the XML.

Revision history for this message
Colin Watson (cjwatson) wrote :

Dropping launchpadlib.testing from the wheel would be an API change that I'm not sure we want to do at the moment (especially since Launchpad's test suite currently relies on that in one place); I'll leave it up to you whether you do that in the Debian package, but it is intended to be useful for testing applications that use launchpadlib.

This change itself looks fine, though, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MANIFEST.in'
2--- MANIFEST.in 2019-11-28 00:06:55 +0000
3+++ MANIFEST.in 2021-10-24 21:39:32 +0000
4@@ -1,4 +1,4 @@
5-exclude MANIFEST.in .bzrignore
6+exclude .bzrignore
7 global-include *.txt *.rst *.xml *.xsl *.png
8 include src/launchpadlib/docs/Makefile src/launchpadlib/docs/conf.py
9 prune src/launchpadlib/docs/_build

Subscribers

People subscribed via source and target branches