Merge lp:~stefanor/launchpad/packageset-destructor into lp:launchpad

[Stefano Rivera]

Export packageset deletion as a destructor operation.

== Summary ==
Follow up to merge 124555.

The deletion API method should be exposed as a destructor operation, which avoids lplib clients getting 404s on deletion.

== Complexity rationale ==

The previous merge was dropped 309 LoC, this adds 1 :)

== Tests ==

Modified lib/lp/soyuz/stories/webservice/xx-packageset.txt to do a HTTP DELETE operation.

== QA ==

edit-acl in lp:~stefanor/ubuntu-archive-tools/edit-packagesets can exercise this.

[William Grant (wgrant)]

You can drop the @export_operation_as, since deletes aren't named. Otherwise great, thanks. Once you've fixed that, give someone a yell and we'll land it for you.

review: Approve (code)

=== modified file 'lib/lp/soyuz/interfaces/packageset.py'
--- lib/lp/soyuz/interfaces/packageset.py	2012-09-11 12:43:45 +0000
+++ lib/lp/soyuz/interfaces/packageset.py	2012-10-01 06:46:21 +0000
@@ -21,6 +21,7 @@
     error_status,
     export_as_webservice_collection,
     export_as_webservice_entry,
+    export_destructor_operation,
     export_factory_operation,
     export_operation_as,
     export_read_operation,
@@ -348,8 +349,7 @@
         :param names: an iterable with string package set names
         """
 
-    @export_write_operation()
-    @export_operation_as('delete')
+    @export_destructor_operation()
     @operation_for_version('devel')
     def destroySelf():
         """Delete the package set."""

=== modified file 'lib/lp/soyuz/stories/webservice/xx-packageset.txt'
--- lib/lp/soyuz/stories/webservice/xx-packageset.txt	2012-09-28 14:48:20 +0000
+++ lib/lp/soyuz/stories/webservice/xx-packageset.txt	2012-10-01 06:46:21 +0000
@@ -108,8 +108,8 @@
 
 And then delete it.
 
-    >>> response = webservice.named_post(
-    ...     '/package-sets/hoary/renamed', 'delete', {}, api_version='devel')
+    >>> response = webservice.delete(
+    ...     '/package-sets/hoary/renamed', {}, api_version='devel')
     >>> print response
     HTTP/1.1 200 Ok
     ...