Merge lp:~stefanor/ibid/twitter-ratelimit-670855 into lp:~ibid-core/ibid/old-trunk-1.6

Proposed by Stefano Rivera
Status: Merged
Approved by: Stefano Rivera
Approved revision: 912
Merged at revision: 998
Proposed branch: lp:~stefanor/ibid/twitter-ratelimit-670855
Merge into: lp:~ibid-core/ibid/old-trunk-1.6
Diff against target: 23 lines (+2/-4)
1 file modified
ibid/plugins/social.py (+2/-4)
To merge this branch: bzr merge lp:~stefanor/ibid/twitter-ratelimit-670855
Reviewer Review Type Date Requested Status
marcog (community) Approve
Max Rabkin Approve
Review via email: mp+46904@code.launchpad.net

Commit message

URLErrors have reasons, but there are other HTTPErrors

Description of the change

Looks like we merged a bug. URLErrors have reasons, but there are other HTTPErrors

To post a comment you must log in.
912. By Stefano Rivera

Actually, we want a little more

Revision history for this message
Max Rabkin (max-rabkin) :
review: Approve
Revision history for this message
marcog (marco-gallotta) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/plugins/social.py'
2--- ibid/plugins/social.py 2011-01-19 19:21:03 +0000
3+++ ibid/plugins/social.py 2011-01-20 16:29:47 +0000
4@@ -120,8 +120,7 @@
5 elif e.code == 404:
6 event.addresponse(u'No such %s', service['name'])
7 else:
8- log.debug(u'%s returned HTTP code %i: %s', service['name'],
9- e.code, e.reason)
10+ log.debug(u'%s raised %s', service['name'], unicode(e))
11 event.addresponse(u'I can only see the Fail Whale')
12
13 @handler
14@@ -135,8 +134,7 @@
15 elif e.code == 404:
16 event.addresponse(u'No such %s', service['user'])
17 else:
18- log.debug(u'%s returned HTTP code %i: %s', service['name'],
19- e.code, e.reason)
20+ log.debug(u'%s raised %s', service['name'], unicode(e))
21 event.addresponse(u'I can only see the Fail Whale')
22 except self.NoTweetsException, e:
23 event.addresponse(

Subscribers

People subscribed via source and target branches