Merge lp:~stefanor/ibid/twitter-breakage into lp:ibid

[Stefano Rivera]

Make "latest tweet from PERSON" work again

Fixes: latest tweet from *twit*

[lp:~stefanor/ibid/twitter-breakage]

1055. By Stefano Rivera on 2012-11-20

Log twitter error messages

[Jonathan Hitchcock (vhata)]

review: Approve

=== modified file 'ibid/plugins/social.py'
--- ibid/plugins/social.py	2012-06-01 14:35:40 +0000
+++ ibid/plugins/social.py	2012-11-20 20:08:20 +0000
@@ -74,22 +74,24 @@
     def remote_latest(self, service, user):
         if service['api'] == 'twitter':
             # Twitter ommits retweets in the JSON and XML results:
-            statuses = generic_webservice('%sstatuses/user_timeline/%s.atom'
-                    % (service['endpoint'], user.encode('utf-8')),
-                    {'count': 1})
+            statuses = generic_webservice('%sstatuses/user_timeline.rss'
+                                          % service['endpoint'], {
+                                              'screen_name': user,
+                                              'count': 1
+                                          })
             tree = ElementTree.fromstring(statuses)
-            latest = tree.find('{http://www.w3.org/2005/Atom}entry')
+            latest = tree.find('.//item')
             if latest is None:
+                if tree.find('.//error'):
+                    log.info('Twitter user_latest returned: %s',
+                             tree.findtext('.//error'))
                 raise self.NoTweetsException(user)
             return {
-                'text': latest.findtext('{http://www.w3.org/2005/Atom}content')
+                'text': latest.findtext('description')
                         .split(': ', 1)[1],
                 'ago': ago(datetime.utcnow() - parse_timestamp(
-                    latest.findtext('{http://www.w3.org/2005/Atom}published'))),
-                'url': [x for x
-                     in latest.getiterator('{http://www.w3.org/2005/Atom}link')
-                     if x.get('type') == 'text/html'
-                  ][0].get('href'),
+                    latest.findtext('pubDate'))),
+                'url': latest.findtext('guid'),
             }
         elif service['api'] == 'laconica':
             statuses = json_webservice('%sstatuses/user_timeline/%s.json'