Ibid

Merge lp:~stefanor/ibid/pysilc-failure-403539 into lp:~ibid-core/ibid/old-trunk-1.6

  1. pysilc-failure-403539
  2. Merge into old-trunk-1.6
Proposed by Stefano Rivera
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: not available
Merged at revision: 857
Proposed branch: lp:~stefanor/ibid/pysilc-failure-403539
Merge into: lp:~ibid-core/ibid/old-trunk-1.6
Diff against target: 13 lines (+3/-0)
1 file modified
ibid/source/silc.py (+3/-0)
To merge this branch: bzr merge lp:~stefanor/ibid/pysilc-failure-403539
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
marcog (community) Approve
Max Rabkin Approve
Review via email: mp+17976@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

I've been meaning to find the source of this for ages. It became pretty obvious today, when working on a pysilc package.

Revision history for this message
Max Rabkin (max-rabkin) wrote :

I don't have a SILC source to test this on, but it looks simple enough.

review: Approve
Revision history for this message
marcog (marco-gallotta) wrote :

Same as Max: can't test, but the change is small.

review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/source/silc.py'
2--- ibid/source/silc.py 2010-01-18 22:53:52 +0000
3+++ ibid/source/silc.py 2010-01-24 17:31:14 +0000
4@@ -199,6 +199,9 @@
5 self.channels.clear()
6 self.users.clear()
7
8+ def failure(self):
9+ self.factory.log.error(u'Connection failure')
10+
11 class SourceFactory(IbidSourceFactory):
12
13 auth = ('implicit',)

Subscribers

People subscribed via source and target branches