Merge lp:~stefanor/ibid/irc-password-789187 into lp:ibid

[Stefano Rivera]

Add the option of specifying an IRC server password.

Untested, but seems straightforward. Anyone know a server to test it against? (I'm not about to set one up just for this...

[Keegan Carruthers-Smith (keegan-csmith)]

I have not tested this either, but your diff seems to agree with the twisted documentation on IRCClient.

review: Approve

[Keegan Carruthers-Smith (keegan-csmith)]

Ok tested on a local irc server, and it works.

[Ibid Branch Auto-Lander (ibid-tarmac)]

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0. Got: 1 Pending.

[Max Rabkin (max-rabkin)]

review: Approve

=== modified file 'ibid/source/irc.py'
--- ibid/source/irc.py	2011-02-09 10:55:45 +0000
+++ ibid/source/irc.py	2011-10-30 20:49:24 +0000
@@ -28,6 +28,8 @@
     def connectionMade(self):
         self.nickname = self.factory.nick.encode('utf-8')
         self.realname = self.factory.realname.encode('utf-8')
+        if self.factory.password is not None:
+            self.password = self.factory.password.encode('utf-8')
 
         irc.IRCClient.connectionMade(self)
 
@@ -312,6 +314,7 @@
     server = Option('server', 'Server hostname')
     nick = Option('nick', 'IRC nick', ibid.config['botname'])
     realname = Option('realname', 'Full Name', ibid.config['botname'])
+    password = Option('password', 'Connection password', None)
     modes = Option('modes', 'User modes to set')
     channels = ListOption('channels', 'Channels to autojoin', [])
     ping_interval = FloatOption('ping_interval', 'Seconds idle before sending a PING', 60)