Merge lp:~stefanor/ibid/feed-notify-help-605584 into lp:~ibid-core/ibid/old-trunk-1.6

[Stefano Rivera]

Include notifying users in feed help

[Max Rabkin (max-rabkin)]

Shouldn't you add Kevin Woodland to the copyright notice, since this was his patch?

[Stefano Rivera (stefanor)]

I suppose one should for attribution, but I think patches of this size are not copyrightable material

[Max Rabkin (max-rabkin)]

review: Approve

[Jonathan Hitchcock (vhata)]

I have serious doubts about how you decide what size a patch is 'copyrightable'. Up to your discretion though.

review: Approve

[lp:~stefanor/ibid/feed-notify-help-605584]

964. By Stefano Rivera on 2010-09-30

Attribution

[Stefano Rivera (stefanor)]

I'm pretty sure that adding a word is not copyrightable. Personally I only add my name to the header of an ibid file when I've done non-trivial modifications to it (and that was the rule I followed when I generated them). I add his name to the list of contributors, though.

[Max Rabkin (max-rabkin)]

> I have serious doubts about how you decide what size a patch is 'copyrightable'.  Up to your discretion though.

If he had not included the patch, we would have generated the exact
same patch. Perhaps that's meaningful?

--Max

[Stefano Rivera (stefanor)]

I wasn't sure what the rules are under South African law here (but AFAIK such trivial patches are usually considered uncopyrightable in at least US law), so I had a read...

Did you know that the copyright holder the exclusive right for:
"performing the computer program in public;"

Anyway, can't find anything that really sheds light on this. Something else to be aware of is that unless the submitter provides a licence with his patch, he hasn't necessarily agreed to release it under the terms of the BSD license. However, with such trivial patches, one can take it as read that he has, as he can't really sue for the infringement of adding one word.

=== modified file 'AUTHORS'
--- AUTHORS	2010-03-19 12:24:38 +0000
+++ AUTHORS	2010-09-30 21:37:42 +0000
@@ -20,3 +20,4 @@
  * Neil Blakey-Milner
  * Marco Gallotta
  * Adrianna Pińska
+ * Kevin Woodland

=== modified file 'ibid/plugins/feeds.py'
--- ibid/plugins/feeds.py	2010-05-11 23:02:12 +0000
+++ ibid/plugins/feeds.py	2010-09-30 21:37:42 +0000
@@ -100,7 +100,7 @@
     add feed <url> as <name>
     remove <name> feed
     list feeds
-    poll <name> feed notify <channel> on <source>
+    poll <name> feed notify ( <channel> | <user> ) on <source>
     stop polling <name> feed
     """
     features = ('feeds',)