Ibid

Merge lp:~stefanor/ibid/factoid-370428 into lp:~ibid-core/ibid/old-trunk-pack-0.92

  1. factoid-370428
  2. Merge into old-trunk-pack-0.92
Proposed by Stefano Rivera
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: 619
Merged at revision: 629
Proposed branch: lp:~stefanor/ibid/factoid-370428
Merge into: lp:~ibid-core/ibid/old-trunk-pack-0.92
Diff against target: None lines
To merge this branch: bzr merge lp:~stefanor/ibid/factoid-370428
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
Michael Gorven Approve
Review via email: mp+6105@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

Bleh, upstream bug

Revision history for this message
Michael Gorven (mgorven) wrote :

 review approve

review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/plugins/factoid.py'
2--- ibid/plugins/factoid.py 2009-05-01 12:17:57 +0000
3+++ ibid/plugins/factoid.py 2009-05-01 22:09:09 +0000
4@@ -140,7 +140,8 @@
5 query = query.filter(FactoidValue.value.op('REGEXP')(pattern))
6 else:
7 pattern = "%%%s%%" % escape_like_re.sub(r'\\\1', pattern)
8- query = query.filter(FactoidValue.value.like(pattern, escape='\\'))
9+ # http://www.sqlalchemy.org/trac/ticket/1400: We can't use .like() in MySQL
10+ query = query.filter('value LIKE :pattern ESCAPE :escape').params(pattern=pattern, escape='\\')
11 if number:
12 try:
13 if literal:

Subscribers

People subscribed via source and target branches