Merge lp:~stefanor/ibid/expose-irc-username into lp:ibid

Proposed by Stefano Rivera on 2013-01-11
Status: Merged
Approved by: Stefano Rivera on 2013-01-30
Approved revision: 1057
Merged at revision: 1059
Proposed branch: lp:~stefanor/ibid/expose-irc-username
Merge into: lp:ibid
Diff against target: 20 lines (+3/-0)
1 file modified
ibid/source/irc.py (+3/-0)
To merge this branch: bzr merge lp:~stefanor/ibid/expose-irc-username
Reviewer Review Type Date Requested Status
Jonathan Hitchcock 2013-01-11 Approve on 2013-01-30
Review via email: mp+142909@code.launchpad.net

Commit message

Allow users to configure the IRC local username

To post a comment you must log in.
Alexander Huemer (alexander-huemer) wrote :

This patch was created because of a request I made on IRC.
I tested the patch, it does what it should.
During my short test no regressions showed up.
I have no objections against merging that patch to mainline.

Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/source/irc.py'
2--- ibid/source/irc.py 2012-12-05 21:05:42 +0000
3+++ ibid/source/irc.py 2013-01-11 14:55:41 +0000
4@@ -30,6 +30,8 @@
5 self.realname = self.factory.realname.encode('utf-8')
6 if self.factory.password is not None:
7 self.password = self.factory.password.encode('utf-8')
8+ if self.factory.username is not None:
9+ self.username = self.factory.username.encode('utf-8')
10
11 irc.IRCClient.connectionMade(self)
12
13@@ -316,6 +318,7 @@
14 nick = Option('nick', 'IRC nick', ibid.config['botname'])
15 realname = Option('realname', 'Full Name', ibid.config['botname'])
16 password = Option('password', 'Connection password', None)
17+ username = Option('username', 'Local username', None)
18 modes = Option('modes', 'User modes to set')
19 channels = ListOption('channels', 'Channels to autojoin', [])
20 ping_interval = FloatOption('ping_interval', 'Seconds idle before sending a PING', 60)

Subscribers

People subscribed via source and target branches

to all changes: