Merge lp:~stefanor/ibid/empty-gdefine-719851 into lp:~ibid-core/ibid/old-trunk-1.6

Proposed by Stefano Rivera on 2011-02-16
Status: Merged
Approved by: Stefano Rivera on 2011-02-20
Approved revision: 1004
Merged at revision: 1010
Proposed branch: lp:~stefanor/ibid/empty-gdefine-719851
Merge into: lp:~ibid-core/ibid/old-trunk-1.6
Diff against target: 13 lines (+2/-1) 1 file modified
To merge this branch: bzr merge lp:~stefanor/ibid/empty-gdefine-719851
Reviewer Review Type Date Requested Status
Max Rabkin Approve on 2011-02-20
Jonathan Hitchcock 2011-02-16 Approve on 2011-02-20
marcog (community) Approve on 2011-02-20
Review via email: mp+49927@code.launchpad.net

Commit Message

Filter out empty definitions in gdefine

To post a comment you must log in.
marcog (marco-gallotta) :
review: Approve
Jonathan Hitchcock (vhata) :
review: Approve
Max Rabkin (max-rabkin) :
review: Approve

Preview Diff

1=== modified file 'ibid/plugins/google.py'
2--- ibid/plugins/google.py 2011-01-17 17:46:59 +0000
3+++ ibid/plugins/google.py 2011-02-16 08:06:22 +0000
4@@ -133,7 +133,8 @@
5
6 definitions = []
7 for li in tree.findall('.//li'):
8- definitions.append(li.text)
9+ if li.text:
10+ definitions.append(li.text)
11
12 if definitions:
13 event.addresponse(u' :: '.join(definitions))

Subscribers

People subscribed via source and target branches