Merge lp:~stefanor/ibid/addresponse-371143 into lp:~ibid-core/ibid/old-trunk-pack-0.92

Proposed by Stefano Rivera
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: 621
Merged at revision: 623
Proposed branch: lp:~stefanor/ibid/addresponse-371143
Merge into: lp:~ibid-core/ibid/old-trunk-pack-0.92
Diff against target: None lines
To merge this branch: bzr merge lp:~stefanor/ibid/addresponse-371143
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
Michael Gorven Approve
Review via email: mp+6140@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Gorven (mgorven) wrote :

 review approve

review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/plugins/admin.py'
2--- ibid/plugins/admin.py 2009-03-08 13:16:28 +0000
3+++ ibid/plugins/admin.py 2009-05-03 18:06:40 +0000
4@@ -17,7 +17,7 @@
5 if processor.name not in plugins:
6 plugins.append(processor.name)
7
8- event.addresponse(u'Plugins: %s', u', '.join(sorted(plugins)))
9+ event.addresponse(u'Plugins: %s', u', '.join(sorted(plugins)) or u'none')
10
11 help['core'] = u'Reloads core modules.'
12 class ReloadCoreModules(Processor):
13
14=== modified file 'ibid/plugins/auth.py'
15--- ibid/plugins/auth.py 2009-05-01 12:22:37 +0000
16+++ ibid/plugins/auth.py 2009-05-03 18:06:40 +0000
17@@ -133,7 +133,7 @@
18 return
19
20 permissions = sorted(u'%s%s' % (permission_values[perm.value], perm.name) for perm in account.permissions)
21- event.addresponse(u'Permissions: %s', u', '.join(permissions))
22+ event.addresponse(u'Permissions: %s', u', '.join(permissions) or u'none')
23
24 @match(r'^list\s+permissions$')
25 def list_permissions(self, event):
26@@ -146,7 +146,7 @@
27 if permission not in permissions:
28 permissions.append(permission)
29
30- event.addresponse(u'Permissions: %s', u', '.join(sorted(permissions)))
31+ event.addresponse(u'Permissions: %s', u', '.join(sorted(permissions)) or u'none')
32
33 class Auth(Processor):
34 u"""auth <credential>"""
35
36=== modified file 'ibid/plugins/bzr.py'
37--- ibid/plugins/bzr.py 2009-05-01 12:17:57 +0000
38+++ ibid/plugins/bzr.py 2009-05-03 18:06:40 +0000
39@@ -69,7 +69,10 @@
40 @match(r'^(?:repos|repositories)$')
41 def handle_repositories(self, event):
42 repositories = self.branches.keys()
43- event.addresponse(u'I know about: %s', u', '.join(sorted(repositories)))
44+ if repositories:
45+ event.addresponse(u'I know about: %s', u', '.join(sorted(repositories)))
46+ else:
47+ event.addresponse(u"I don't know about any repositories")
48
49 def remote_committed(self, repository, start, end=None):
50 commits = self.get_commits(repository, start, end)
51
52=== modified file 'ibid/plugins/dict.py'
53--- ibid/plugins/dict.py 2009-05-01 12:17:57 +0000
54+++ ibid/plugins/dict.py 2009-05-03 18:06:40 +0000
55@@ -51,7 +51,7 @@
56 def handle_dictionaries(self, event):
57 connection = Connection(self.server, self.port)
58 dictionaries = connection.getdbdescs()
59- event.addresponse(u'Dictionaries: %s', u', '.join(sorted(dictionaries.keys())))
60+ event.addresponse(u'Dictionaries: %s', u', '.join(sorted(dictionaries.keys())) or u'none')
61
62 @match(r'^strater?gies$')
63 def handle_strategies(self, event):
64
65=== modified file 'ibid/plugins/help.py'
66--- ibid/plugins/help.py 2009-03-08 13:16:28 +0000
67+++ ibid/plugins/help.py 2009-05-03 18:06:40 +0000
68@@ -27,7 +27,7 @@
69 if feature not in features:
70 features.append(feature)
71
72- event.addresponse(u'Features: %s', u' '.join(sorted(features)))
73+ event.addresponse(u'Features: %s', u' '.join(sorted(features)) or u'none')
74
75 @match(r'^help\s+(.+)$')
76 def help(self, event, feature):
77
78=== modified file 'ibid/plugins/sources.py'
79--- ibid/plugins/sources.py 2009-03-16 20:55:20 +0000
80+++ ibid/plugins/sources.py 2009-05-03 18:06:40 +0000
81@@ -48,10 +48,10 @@
82 for name, source in ibid.sources.items():
83 url = source.url()
84 sources.append(url and u'%s (%s)' % (name, url) or name)
85- event.addresponse(u'Sources: %s', u', '.join(sorted(sources)))
86+ event.addresponse(u'Sources: %s', u', '.join(sorted(sources)) or u'none')
87
88 @match(r'^list\s+configured\s+sources$')
89 def listall(self, event):
90- event.addresponse(u'Configured sources: %s', u', '.join(sorted(ibid.config.sources.keys())))
91+ event.addresponse(u'Configured sources: %s', u', '.join(sorted(ibid.config.sources.keys())) or u'none')
92
93 # vi: set et sta sw=4 ts=4:

Subscribers

People subscribed via source and target branches