Code review comment for lp:~stefankrupop/maas/recs

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Thanks for the fixes! I see that the tests are passing after I merge your branch to trunk.

I think the next step is to talk to the team about how to support christmann RECS|Box in MAAS, given that we have no way to test it directly. As it stands now, we risk breaking your code unintentionally. What is your role with regard to the christmann RECS|Box product, and can we expect that this code will be maintained long-term?

My other question is, I notice that the power type is just 'recs', is that specific enough for 'christmann RECS|Box' or might it be confused with another meaning of "RECS"?

If you could e-mail me directly so we can start that conversation, that would be appreciated. You can find my @canonical.com address on my Launchpad profile[1]. Thanks in advance!

[1]: https://launchpad.net/~mpontillo

review: Needs Information

« Back to merge proposal