Code review comment for lp:~stefan-schwarzburg/qreator/touch-reorganized

David Planella (dpm) wrote :

Looks good to me, thanks!

Before merging to trunk, I've gone ahead and did a few extra changes. Mostly they were to fix some indentations, but the main one is that I renamed file names such as CreatorPage to Creator, as I thought they should not be dependent on the base component, especially if we change the UI at some point and they're no longer pages. I left the *Canvas and *Toolbar ones unchanged, as I thought these are intrinsically associated with their component, and the name helps clarifying what they are.

Let me know if you're ok with this changes. If not, we can always discuss and revert.

You can see the actual changes doing:

    bzr qdiff -r 14.1.1..15

review: Approve

« Back to merge proposal