Merge lp:~stefan-schwarzburg/qreator/fix-bug-1017674 into lp:~dpm/qreator/trunk
Proposed by
Schwarzburg
Status: | Merged |
---|---|
Merged at revision: | 118 |
Proposed branch: | lp:~stefan-schwarzburg/qreator/fix-bug-1017674 |
Merge into: | lp:~dpm/qreator/trunk |
Diff against target: |
25 lines (+13/-0) 1 file modified
qreator/qrcodes/QRCodeURLGtk.py (+13/-0) |
To merge this branch: | bzr merge lp:~stefan-schwarzburg/qreator/fix-bug-1017674 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella | Approve | ||
Review via email: mp+117884@code.launchpad.net |
Description of the change
This implements the more complicated but preferred version:
- check if the entry starts with a supported protocol (support is taken from the combobox entries)
- if so, remove that protocol and
- select the appropriate protocol of the combobox
It is actually not that complicated, so we should stick with that...
To post a comment you must log in.
Looks great and works great, as discussed in the implementation e-mail a while ago. Merged, thanks!