Code review comment for lp:~stefan-opener/therp-backports/addons61-lp939588-check_partner_category_id_is_not_list

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

if you have a context like
{'category_id': [(6, 0, 42)]}
as you mention in your bug report, the condition you add evaluates to False.

Shouldn't it be
not context.get('category_id') or not isinstance(context['category_id'], (int, long))
?

review: Needs Fixing

« Back to merge proposal