Merge lp:~statik/ubuntuone-client/less-logs-more-privacy into lp:ubuntuone-client

Proposed by Elliot Murphy
Status: Merged
Approved by: Zachery Bir
Approved revision: 193
Merged at revision: not available
Proposed branch: lp:~statik/ubuntuone-client/less-logs-more-privacy
Merge into: lp:ubuntuone-client
Diff against target: None lines
To merge this branch: bzr merge lp:~statik/ubuntuone-client/less-logs-more-privacy
Reviewer Review Type Date Requested Status
Zachery Bir (community) Approve
John O'Brien (community) Approve
Review via email: mp+10885@code.launchpad.net

Commit message

Stop attaching the u1 client log and the u1sync log to apport bug reports because they have filenames in them and users are reporting this as a privacy concern because the apport retracer makes bugs public once they are marked as a duplicate of a public bug.

To post a comment you must log in.
Revision history for this message
Elliot Murphy (statik) wrote :

Stop attaching the u1 client log and the u1sync log because they have filenames in them and users are reporting this as a privacy concern because the apport retracer makes bugs public once they are marked as a duplicate of a public bug.

Revision history for this message
John O'Brien (jdobrien) :
review: Approve
Revision history for this message
Zachery Bir (urbanape) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/source_ubuntuone-client.py'
2--- data/source_ubuntuone-client.py 2009-08-05 18:01:19 +0000
3+++ data/source_ubuntuone-client.py 2009-08-30 01:49:27 +0000
4@@ -32,10 +32,8 @@
5
6 def add_info(report):
7 """add report info"""
8- attach_file_if_exists(report, u1_client_log)
9 attach_file_if_exists(report, u1_except_log)
10 attach_file_if_exists(report, u1_oauth_log)
11- attach_file_if_exists(report, u1_u1sync_log)
12
13 if not apport.packaging.is_distro_package(report['Package'].split()[0]):
14 report['ThirdParty'] = 'True'

Subscribers

People subscribed via source and target branches