Merge lp:~statik/mup/stop-the-line into lp:~niemeyer/mup/trunk

[Elliot Murphy]

[Elliot Murphy (statik)]

I'm requesting a review of this branch as I'd like some implementation advice - it's not yet ready to land.

I think I've got the plugin skeleton hooked up correctly, and a basic entry point for unit tests of the plugin, but I'm not sure how to write a unit tests that checks to see if the plugin responds correctly to a command. A quick glance over the plugin and a tip or two on getting the unit test written will help me a lot, and should give me enough to figure out the rest of it. Thanks!

[Gustavo Niemeyer (niemeyer)]

As we discussed over IRC:

<niemeyer> Yeah, I've had a look at the branch and it's not finished indeed
<niemeyer> You've asked something about testing there
<niemeyer> In mup_server.erl, there are some examples of how this could be tested
<niemeyer> You can actually start the plugin on tests, by starting the supervisor
<niemeyer> Check out the mup_server_test_ function in this file
<niemeyer> It has the needed logic for starting the supervisors, and waiting for them to die at the end

If you need further help, please ping me.

[Gustavo Niemeyer (niemeyer)]

review: Needs Fixing (pre-implementation advice)

[lp:~statik/mup/stop-the-line]

33. By Elliot Murphy on 2009-04-04

Merge trunk.

[Gustavo Niemeyer (niemeyer)]

Rejecting, since I believe you're not interesting on it anymore.

[Gustavo Niemeyer (niemeyer)]

s/interesting/interested/.

Unmerged revisions

33. By Elliot Murphy on 2009-04-04

Merge trunk.

32. By Elliot Murphy on 2008-12-12

Added a couple of other unit tests.

31. By Elliot Murphy on 2008-12-12

fix some unused variable warnings

30. By Elliot Murphy on 2008-12-12

a basic skeleton of my plugin, with a failing test