Code review comment for lp:~statik/desktopcouch/dc-load-design-docs

Revision history for this message
Eric Casteleijn (thisfred) wrote :

I get these errors:

===============================================================================
[ERROR]: desktopcouch.records.tests.test_field_registry.TestFieldMapping.test_mergeable_list_field_mapping

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 168000268 [0.995854854584s] called=0 cancelled=0 LoopingCall<1.0>(exit_on_success, *(), **{})()>
<DelayedCall 168000044 [1.56556606293s] called=0 cancelled=0 reconnector()>
<DelayedCall 167997580 [28.9958992004s] called=0 cancelled=0 exit_on_timeout()>
===============================================================================
[ERROR]: desktopcouch.records.tests.test_server.TestCouchDatabase.test_delete_record

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 161, in run
    self.setUp()
  File "/home/eric/canonical/desktopcouch/r-statik-sil/desktopcouch/records/tests/test_server.py", line 42, in setUp
    self.database = CouchDatabase(self.dbname, create=True)
  File "/home/eric/canonical/desktopcouch/r-statik-sil/desktopcouch/records/server.py", line 58, in __init__
    if database not in self._server:
  File "/usr/lib/pymodules/python2.6/couchdb/client.py", line 120, in __contains__
    self.resource.head(validate_dbname(name))
  File "/usr/lib/pymodules/python2.6/couchdb/client.py", line 977, in head
    return self._request('HEAD', path, headers=headers, **params)
  File "/usr/lib/pymodules/python2.6/couchdb/client.py", line 1010, in _request
    resp, data = _make_request()
  File "/usr/lib/pymodules/python2.6/couchdb/client.py", line 1005, in _make_request
    body=body, headers=headers)
  File "/usr/lib/pymodules/python2.6/httplib2/__init__.py", line 1068, in request
    (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
  File "/usr/lib/pymodules/python2.6/httplib2/__init__.py", line 872, in _request
    (response, content) = self._conn_request(conn, request_uri, method, body, headers)
  File "/usr/lib/pymodules/python2.6/httplib2/__init__.py", line 842, in _conn_request
    response = conn.getresponse()
  File "/usr/lib/python2.6/httplib.py", line 950, in getresponse
    response.begin()
  File "/usr/lib/python2.6/httplib.py", line 390, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python2.6/httplib.py", line 348, in _read_status
    line = self.fp.readline()
  File "/usr/lib/python2.6/socket.py", line 395, in readline
    data = recv(1)
socket.error: [Errno 4] Interrupted system call
===============================================================================
[ERROR]: desktopcouch.tests.test_start_local_couchdb.TestUpdateDesignDocuments.test_create_databases_and_design_docs

Traceback (most recent call last):
  File "/home/eric/canonical/desktopcouch/r-statik-sil/desktopcouch/tests/test_start_local_couchdb.py", line 132, in test_create_databases_and_design_docs
    mocker.verify()
  File "/home/eric/canonical/desktopcouch/r-statik-sil/desktopcouch/../contrib/mocker.py", line 503, in verify
    raise AssertionError(os.linesep.join(message))
exceptions.AssertionError: [Mocker] Unmet expectations:

=> desktopcouch.records.server.CouchDatabase('cfg', create=True)
 - Performed fewer times than expected.

=> desktopcouch.records.server.CouchDatabase('cfg_and_empty_design', create=True)
 - Performed fewer times than expected.

=> desktopcouch.records.server.CouchDatabase('cfg_and_design_no_views', create=True)
 - Performed fewer times than expected.

=> desktopcouch.records.server.CouchDatabase('cfg_and_design_one_view_no_map', create=True)
 - Performed fewer times than expected.

=> desktopcouch.records.server.CouchDatabase('cfg_and_design_one_view_map_no_reduce', create=True)
 - Performed fewer times than expected.

=> dbmock1.add_view('view1', 'cfg_and_design_one_view_map_no_reduce:map', None, 'doc1')
 - Performed fewer times than expected.

=> desktopcouch.records.server.CouchDatabase('cfg_and_design_one_view_map_reduce', create=True)
 - Performed fewer times than expected.

=> dbmock2.add_view('view1', 'cfg_and_design_one_view_map_reduce:map', 'cfg_and_design_one_view_map_reduce:reduce', 'doc1')
 - Performed fewer times than expected.

=> desktopcouch.records.server.CouchDatabase('cfg_and_design_two_views_map_reduce', create=True)
 - Performed fewer times than expected.

=> dbmock3.add_view('view1', 'cfg_and_design_two_views_map_reduce:map1', 'cfg_and_design_two_views_map_reduce:reduce1', 'doc1')
 - Performed fewer times than expected.

=> dbmock3.add_view('view2', 'cfg_and_design_two_views_map_reduce:map2', 'cfg_and_design_two_views_map_reduce:reduce2', 'doc1')
 - Performed fewer times than expected.

-------------------------------------------------------------------------------

The first one I seem to get on any branch and even on trunk, so that's unrelated, but still mysterious. The second one I've seen come and go, it usually only occurs when running the tests more than once. The last one seems particular to this branch, but I may not be running the tests correctly.

review: Needs Fixing

« Back to merge proposal