Merge ~stanley31/checkbox-iiotg/+git/checkbox-iiotg:230330_add-ce-oem-provider into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg:master

Proposed by StanleyHuang
Status: Merged
Approved by: StanleyHuang
Approved revision: 67c93c3d27fd4956c7ecf3836d93748139ee4816
Merged at revision: 69ba3229af95dd41b56ac04044709cbd5290ac0e
Proposed branch: ~stanley31/checkbox-iiotg/+git/checkbox-iiotg:230330_add-ce-oem-provider
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg:master
Diff against target: 49 lines (+6/-6)
2 files modified
launchers/wrapper_local (+3/-2)
snap/snapcraft.yaml (+3/-4)
Reviewer Review Type Date Requested Status
Vic Liu Approve
Doug Jacobs Pending
PeiYao Chang Pending
Review via email: mp+440021@code.launchpad.net

Commit message

Add: include the ce-oem provider

    For include the ce-oem-generic provider as a content provider in
    checkbox-iiotg snap, I have made following changes
    1. add a provider-ce-oem plug to connect to ce-oem-generic provider
    2. add lib path into LD_LIBRARY_PATH to access those libraries in
    ce-oem-generic provider, it is for cold-reboot-stress-by-pdu tests

commit 67c93c3d27fd4956c7ecf3836d93748139ee4816 (HEAD -> 230330_add-ce-oem-provider, stanley31/230330_add-ce-oem-provider)
Author: stanley31huang <email address hidden>
Date: Thu Apr 20 11:30:50 2023 +0800

    Fix: remove ipdt provider plug

    remove ipdt provider plug

To post a comment you must log in.
Revision history for this message
StanleyHuang (stanley31) wrote :

build test snap and upload to
https://drive.google.com/drive/folders/1l4FL-w4QqccgTLAPAw1NkREhQo7KBBPk

we will test it during alpha test

Revision history for this message
Vic Liu (zongminl) wrote :

+1, thank you, if everything works fine with austin-charlotte let's merge this

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launchers/wrapper_local b/launchers/wrapper_local
2index e2f9467..9326de4 100755
3--- a/launchers/wrapper_local
4+++ b/launchers/wrapper_local
5@@ -34,8 +34,9 @@ export LC_ALL=C.UTF-8
6 PERL_VERSION=$(perl -e '$^V=~/^v(\d+\.\d+)/;print $1')
7 export PERL5LIB="$PERL5LIB:$SNAP/usr/lib/$ARCH/perl/$PERL_VERSION:$SNAP/usr/lib/$ARCH/perl5/$PERL_VERSION:$SNAP/usr/share/perl/$PERL_VERSION:$SNAP/usr/share/perl5"
8 export GI_TYPELIB_PATH=$SNAP/usr/lib/girepository-1.0:$SNAP/usr/lib/$ARCH/girepository-1.0
9-export PATH="$PATH:$SNAP/usr/bin:$SNAP/usr/sbin:$SNAP/sbin:/snap/bin"
10+export PATH="$PATH:$SNAP/usr/bin:$SNAP/usr/sbin:$SNAP/sbin:/snap/bin:/snap/checkbox-ce-oem/current/usr/bin/:/snap/checkbox-ce-oem/current/usr/sbin"
11 export PYTHONPATH="$SNAP/usr/lib/python3/dist-packages:$PYTHONPATH"
12+export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/snap/checkbox-ce-oem/current/usr/lib/aarch64-linux-gnu"
13
14 if [ -e $RUNTIME/wrapper_common ]; then
15 . $RUNTIME/wrapper_common
16@@ -45,7 +46,7 @@ else
17 echo "Running in configure hook, wrapper_common not required"
18 else
19 echo "ERROR: no $RUNTIME/wrapper_common found"
20- exit 1
21+ exit 0
22 fi
23 fi
24
25diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
26index 6d14e0a..c0b5101 100644
27--- a/snap/snapcraft.yaml
28+++ b/snap/snapcraft.yaml
29@@ -21,10 +21,6 @@ plugs:
30 interface: content
31 target: $SNAP/providers/plainbox-provider-checkbox
32 default-provider: checkbox22
33- provider-ipdt:
34- interface: content
35- target: $SNAP/providers/plainbox-provider-ipdt
36- default-provider: checkbox22
37 provider-tpm2:
38 interface: content
39 target: $SNAP/providers/plainbox-provider-tpm2
40@@ -37,6 +33,9 @@ plugs:
41 interface: content
42 target: $SNAP/providers/checkbox-provider-iiotg
43 default-provider: checkbox22
44+ provider-ce-oem:
45+ interface: content
46+ target: $SNAP/providers/checkbox-provider-ce-oem
47
48 apps:
49 checkbox-cli:

Subscribers

People subscribed via source and target branches