Merge lp:~stan/openobject-addons/lp1003819b into lp:openobject-addons

[Tristan Hill]

[IMP] log stderr output

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

does not solve the whole problem: the user has no feedback about what went wrong.

review: Disapprove

[Fabien (Open ERP) (fp-tinyerp)]

I agree with Alexandre.

Unmerged revisions

6975. By Tristan Hill on 2012-07-04

[IMP] log stderr output

=== modified file 'report_webkit/webkit_report.py'
--- report_webkit/webkit_report.py	2012-06-22 06:48:54 +0000
+++ report_webkit/webkit_report.py	2012-07-04 09:11:22 +0000
@@ -161,7 +161,11 @@
             command.append(html_file.name)
         command.append(out_filename)
         try:
-            status = subprocess.call(command, stderr=subprocess.PIPE) # ignore stderr
+            p = subprocess.Popen(command, stderr=subprocess.PIPE)
+            for line in p.stderr:
+                logger.error(line)
+            status = p.wait()
+            p.stderr.close()
             if status :
                 raise except_osv(
                                 _('Webkit raise an error' ),