Merge lp:~ssweeny/ubuntu/raring/pbuilder-scripts/pbuilder-scripts-fixes into lp:ubuntu/raring/pbuilder-scripts

Proposed by Scott Sweeny
Status: Merged
Merged at revision: 5
Proposed branch: lp:~ssweeny/ubuntu/raring/pbuilder-scripts/pbuilder-scripts-fixes
Merge into: lp:ubuntu/raring/pbuilder-scripts
Diff against target: 43 lines (+14/-1)
3 files modified
debian/changelog (+8/-0)
pcreate (+3/-1)
pget (+3/-0)
To merge this branch: bzr merge lp:~ssweeny/ubuntu/raring/pbuilder-scripts/pbuilder-scripts-fixes
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Ubuntu branches Pending
Review via email: mp+134755@code.launchpad.net

Description of the change

This branch fixes a couple of regressions from a previous (Canonical-internal) incarnation of this package.

Specifically when running 'pcreate foo' you should end up with ~/Projects/foo in your $HOME directory (LP: #1079316). Also, when PBUILDER_SRCDIR_FORMAT is set to "pkg" you should get an extra directory layer for that package when running 'pget'. (LP: #1079899)

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks. Uploaded.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-11-06 20:02:39 +0000
3+++ debian/changelog 2012-11-16 22:50:25 +0000
4@@ -1,3 +1,11 @@
5+pbuilder-scripts (19) raring; urgency=low
6+
7+ * pcreate: Create project directory to match the new chroot (LP: #1079316)
8+ * pget: Correctly respond to the value of PBUILDER_SRCDIR_FORMAT
9+ (LP: #1079899)
10+
11+ -- Scott Sweeny <scott.sweeny@canonical.com> Fri, 16 Nov 2012 16:31:59 -0500
12+
13 pbuilder-scripts (18) raring; urgency=low
14
15 [ Mike Carifio ]
16
17=== modified file 'pcreate'
18--- pcreate 2012-07-25 15:59:43 +0000
19+++ pcreate 2012-11-16 22:50:25 +0000
20@@ -116,7 +116,9 @@
21 DEBOOTSTRAP_ARGS="--debootstrapopts --variant=buildd --debootstrapopts --arch=$ARCH"
22 fi
23
24-
25+# Create the Project directory
26+SRCDIR=${PBUILDER_SRCDIR:-$HOME/Projects}
27+mkdir -p "$SRCDIR/$PROJ"
28
29 # Now, we didn't tell pbuilder about the user's input sources.list. We'll set
30 # that up as an extra step below (this allows user to input https sources even
31
32=== modified file 'pget'
33--- pget 2012-07-25 15:59:43 +0000
34+++ pget 2012-11-16 22:50:25 +0000
35@@ -39,6 +39,9 @@
36 ;;
37 esac
38
39+# Make sure the right source directory is present
40+mkdir -p "$srcdir"
41+
42 uid=$(id -u)
43 gid=$(id -g)
44

Subscribers

People subscribed via source and target branches

to all changes: