Merge lp:~sseman/juju-ci-tools/update-calls-to-dumps_logs into lp:juju-ci-tools

Proposed by Seman
Status: Merged
Merged at revision: 1052
Proposed branch: lp:~sseman/juju-ci-tools/update-calls-to-dumps_logs
Merge into: lp:juju-ci-tools
Diff against target: 38 lines (+3/-3)
3 files modified
assess_heterogeneous_control.py (+1/-1)
deploy_stack.py (+1/-1)
test_deploy_stack.py (+1/-1)
To merge this branch: bzr merge lp:~sseman/juju-ci-tools/update-calls-to-dumps_logs
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+266321@code.launchpad.net

Description of the change

Since the dump_log() signature has been changed, this branch updates calls to the function.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'assess_heterogeneous_control.py'
2--- assess_heterogeneous_control.py 2015-06-22 00:14:18 +0000
3+++ assess_heterogeneous_control.py 2015-07-29 20:26:13 +0000
4@@ -51,7 +51,7 @@
5 try:
6 yield
7 finally:
8- dump_logs(client, host, log_dir)
9+ dump_logs(client.env, host, log_dir)
10 except:
11 client.destroy_environment()
12 raise
13
14=== modified file 'deploy_stack.py'
15--- deploy_stack.py 2015-07-29 17:11:42 +0000
16+++ deploy_stack.py 2015-07-29 20:26:13 +0000
17@@ -414,7 +414,7 @@
18 client.bootstrap(upload_tools)
19 except:
20 if host is not None and sys.platform != 'win32':
21- dump_logs(client, host, log_dir, bootstrap_id)
22+ dump_logs(client.env, host, log_dir, bootstrap_id)
23 raise
24 try:
25 if host is None:
26
27=== modified file 'test_deploy_stack.py'
28--- test_deploy_stack.py 2015-07-29 17:11:42 +0000
29+++ test_deploy_stack.py 2015-07-29 20:26:13 +0000
30@@ -738,7 +738,7 @@
31 with boot_context('bar', client, 'baz', [], None, None, None,
32 'log_dir', keep_env=False, upload_tools=True):
33 pass
34- dl_mock.assert_called_once_with(client, 'baz', 'log_dir', None)
35+ dl_mock.assert_called_once_with(client.env, 'baz', 'log_dir', None)
36
37
38 class TestDeployJobParseArgs(TestCase):

Subscribers

People subscribed via source and target branches