Merge lp:~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-751807 into lp:ubuntu/natty/likewise-open

[Scott Salley]

No code was changed, just the preinst script.

This change corrects the likewise-open.preinst script to shutdown the daemons in Likewise Open 5.4 on upgrade. Somehow I missed the fact that much of the upgrade related code was not being called for upgrades from Likweise Open 5.4 -- probably because the only real task from upgrading from 5.4 is to make sure 5.4 is shutdown cleanly.

Test by installing likewise-open in Ubuntu 10.10 and upgrading to Natty.

For expediency in testing, I put a 'hold' on likewise-open in Ubuntu 10.10, did a Natty upgrade, and then took a snapshot of my VM. I then tested the likewise-open package I built by starting the snapshot and installing with dpkg. Anyone see a problem with doing an upgrade test like this?

[Dustin Kirkland  (kirkland)]

Hi Scott,

I'm going to approve/merge this for Natty.

However, calling /etc/init.d/* directly from preinst/postinst scripts is not recommended.

Instead, you're supposed to use update-rc.d. See the Debian Policy Manual, section 9.3.3:
 * http://www.debian.org/doc/debian-policy/ch-opersys.html

Grepping through your debian directory, I see ~30 or so "violations", so I accepted your merge proposal as-is, in the interest of consistency.

I would recommend taking a look at this in depth for a future release (after Natty). Ping me in IRC if you have more questions!

Thanks!

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2011-03-21 19:28:39 +0000
+++ debian/changelog	2011-04-06 17:29:25 +0000
@@ -1,3 +1,9 @@
+likewise-open (6.0.0.53010-4ubuntu4) natty; urgency=low
+
+  * debian/likewise-open.preinst now stops daemons during upgrade (LP: #751807)
+
+ -- Scott Salley <[e-mail]>  Tue, 5 Apr 2011 13:52:58 -0800
+
 likewise-open (6.0.0.53010-4ubuntu3) natty; urgency=low
 
   * remove stale pid files during installation and daemon exit. (LP: #737362)

=== modified file 'debian/likewise-open.preinst'
--- debian/likewise-open.preinst	2011-03-21 19:28:39 +0000
+++ debian/likewise-open.preinst	2011-04-06 17:29:25 +0000
@@ -190,6 +190,28 @@
         # from 5.0
         rm_conffile /etc/init.d/npcmuxd
     fi
+
+    if dpkg --compare-versions "$2" lt-nl "6.0.0"; then
+        # Shutdown old daemons nicely
+        if [ -f /etc/init.d/lsassd ]
+        then
+            exec_log "/etc/init.d/lsassd stop"
+        fi
+
+        for daemon in $DAEMONS_TO_HALT
+        do
+            if [ -x /etc/init.d/$daemon ]; then
+                exec_logfile "/etc/init.d/$daemon stop"
+            fi
+            exec_logfile "pkill -TERM -x $daemon"
+            exec_logfile "pkill -KILL -x $daemon"
+            exec_logfile "rm -f /var/run/$daemon.pid"
+        done
+
+        logfile "Snapshot of processes after stopping daemons"
+        exec_logfile "ps ax"
+
+    fi
     return 0
     ;;