Merge lp:~srazi/qpdfview/page-labels-fixes into lp:qpdfview
Proposed by
Razi Alavizadeh
Status: | Merged |
---|---|
Merged at revision: | 1710 |
Proposed branch: | lp:~srazi/qpdfview/page-labels-fixes |
Merge into: | lp:qpdfview |
Diff against target: |
47 lines (+17/-5) 1 file modified
sources/mainwindow.cpp (+17/-5) |
To merge this branch: | bzr merge lp:~srazi/qpdfview/page-labels-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Reichold | Approve | ||
Review via email: mp+236940@code.launchpad.net |
Description of the change
A small fix and an improvement related to page labels.
To post a comment you must log in.
Hello Razi,
thanks for the merge request. However, I am not sure I understand it correctly. Does it address the problem that the backend could always return English-locale page labels and we would prefer our default page label in this case? If so, wouldn't it be better to fix this once in line 395 of documentview.cpp? (I.e. check if "m_pages.at(number - 1)->label().toInt() != number" before setting "label"?)
Best regards, Adam.