qpdfview

Code review comment for lp:~srazi/qpdfview/bookmark-work

  1. bookmark-work
  2. Merge into trunk
Revision history for this message
Adam Reichold (adamreichold) wrote :

Hello again,

just two general remarks:

* I think BookmarkDialog::appendComment should become Bookmark::append since it is not involved with the presentation layer at all. (And it is IMHO that only the comment can sensibly be appended to.)

* The text rendering code of BookmarkItemDelegate seems to have quite a bit of duplication with e.g. SearchItemDelegate. Could this be factored out into some common text rendering code? Can we not somehow reuse the existing text rendering used to e.g. draw QLabel?

Best regards,
Adam

« Back to merge proposal