Merge lp:~spiv/bzr/just-add-repr-687653-2.2 into lp:bzr/2.2
Proposed by
Andrew Bennetts
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Martin Pool | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 5115 | ||||
Proposed branch: | lp:~spiv/bzr/just-add-repr-687653-2.2 | ||||
Merge into: | lp:bzr/2.2 | ||||
Diff against target: |
28 lines (+7/-0) 2 files modified
NEWS (+4/-0) bzrlib/errors.py (+3/-0) |
||||
To merge this branch: | bzr merge lp:~spiv/bzr/just-add-repr-687653-2.2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pool | Approve | ||
Review via email: mp+43319@code.launchpad.net |
Commit message
Override __repr__ in NotBranchError to avoid side-effects during repr(e).
Description of the change
An simpler alternative to <https:/
To post a comment you must log in.
This is a nice minimal fix for 2.2, and apparently fixes the issue in production.
I think generally we shouldn't have any objects doing real work from their str or repr method, and exceptions should be a lot like value objects.
Perhaps we should have an optional ".hint()" method that the ui can call.
I am kind of inclined to delete this in trunk but it's not really a priority.