Code review comment for lp:~spiv/bzr/hpss-perm-denied-during-push-create

Andrew Bennetts (spiv) wrote :

Catches and translates ErrorFromSmartServer in RemoteBzrDirFormat. This makes it consistent with other callers of (in bzrlib.remote and bzrlib.transport.remote), and fixes ugly tracebacks when creating new BzrDirs on a smart server.

This also adds some very basic unit tests for the BzrDirFormat.initialize_ex verb, and refactors the RemoteBzrDirFormat.initialize_on_transport_ex a little to make that testing easier. The test coverage here is far from great, but it is a least a small improvement.

« Back to merge proposal