Merge lp:~spiv/bzr/hpss-log-noise into lp:~bzr/bzr/trunk-old
Proposed by
Andrew Bennetts
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~spiv/bzr/hpss-log-noise |
Merge into: | lp:~bzr/bzr/trunk-old |
Diff against target: | 52 lines |
To merge this branch: | bzr merge lp:~spiv/bzr/hpss-log-noise |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+8922@code.launchpad.net |
To post a comment you must log in.
The fix has two simple parts:
* don't log UnknownSmartMethod exceptions from the request handler, as these
are not exceptional (or particularly interesting) events for the server.
* don't bother trying to invoke do_chunk or do_end if there is no live command
in the request handler (e.g. because the request we are parsing is currently
for an unknown method). Unknown requests should simply be consumed and
discarded (after sending an UnknownMethod response, of course).
This fixes bug #338561.
-Andrew.