Merge lp:~spam-mason/flickrfs/fix-https into lp:ubuntu/vivid/flickrfs

Proposed by ClashTheBunny
Status: Merged
Merged at revision: 9
Proposed branch: lp:~spam-mason/flickrfs/fix-https
Merge into: lp:ubuntu/vivid/flickrfs
Diff against target: 30 lines (+3/-3)
1 file modified
flickrfs/flickrapi.py (+3/-3)
To merge this branch: bzr merge lp:~spam-mason/flickrfs/fix-https
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
Ubuntu branches Pending
Review via email: mp+242047@code.launchpad.net

Description of the change

Flickr now requires https. This fix works for me when I perform the same change on utopic's package.

https://twitter.com/FlickrAPI/status/482530019906830338

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Tested to be working, thanks a lot for the contribution! Sponsoring.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'flickrfs/flickrapi.py'
2--- flickrfs/flickrapi.py 2007-03-29 18:11:48 +0000
3+++ flickrfs/flickrapi.py 2014-11-18 09:24:22 +0000
4@@ -245,7 +245,7 @@
5 if not self.__handlerCache.has_key(method):
6 def handler(_self = self, _method = method, **arg):
7 _method = "flickr." + _method.replace("_", ".")
8- url = "http://" + FlickrAPI.flickrHost + \
9+ url = "https://" + FlickrAPI.flickrHost + \
10 FlickrAPI.flickrRESTForm
11 arg["method"] = _method
12 # Modified here: use default api_key and auth_token if not supplied
13@@ -298,7 +298,7 @@
14
15 data = {"api_key": self.apiKey, "frob": frob, "perms": perms}
16 data["api_sig"] = self.__sign(data)
17- return "http://%s%s?%s" % (FlickrAPI.flickrHost, \
18+ return "https://%s%s?%s" % (FlickrAPI.flickrHost, \
19 FlickrAPI.flickrAuthForm, urllib.urlencode(data))
20
21 #-------------------------------------------------------------------
22@@ -337,7 +337,7 @@
23 if not 'api_key' in arg: arg["api_key"] = self.apiKey
24 if not 'auth_token' in arg: arg['auth_token'] = self.token
25 arg["api_sig"] = self.__sign(arg)
26- url = "http://" + FlickrAPI.flickrHost + FlickrAPI.flickrUploadForm
27+ url = "https://" + FlickrAPI.flickrHost + FlickrAPI.flickrUploadForm
28
29 # construct POST data
30 # boundary = "===beej=jorgensen==========7d45e178b0434"

Subscribers

People subscribed via source and target branches

to all changes: