lp:sosreport

Created by Adam Stokes and last modified
Get this branch:
bzr branch lp:sosreport

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
sosreport
Project:
sosreport
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://github.com/sosreport/sosreport.git.

The next import is scheduled to run .

Last successful import was .

Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 25 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 15 seconds — see the log

Recent revisions

3993. By Jake Hunsaker <email address hidden>

[insights] Collect /var/lib/insights

Adds collection of `/var/lib/insights` to the `insights` plugin.

There is an `.egg` in this location but rather than individually
skipping it, add a global forbidden path on all eggs.

Related: RHBZ#2103233

Signed-off-by: Jake Hunsaker <email address hidden>

3992. By Jake Hunsaker <email address hidden>

[logs] Drop catalog from `this` and `last` boot

Removes catalog entries from the journal collection for `this` and
`last` boot collections.

Closes: #2132

Signed-off-by: Jake Hunsaker <email address hidden>

3991. By Jake Hunsaker <email address hidden>

[tests] Increase default timeout

For our CI tests, CPU resources are not guaranteed which in turn can
cause longer-than-expected run times for test executions. In practice,
this is only seen occasionally but it requires manual intervention when
the timeouts are hit (and thus far it has been seen that the changes
these timeouts are hit on are not actually causing the timeouts).

Previous conversations have revolved around improving test efficiency,
however this seems unlikely given the nature of some of the test setup
and further, even with the most efficienct approach possible we would
still be at the whim of resource availability.

As such, increase the default timeout to account for this resource
consideration.

Closes: #2700

Signed-off-by: Jake Hunsaker <email address hidden>

3990. By Jake Hunsaker <email address hidden>

[PackageManager] Make pkg_by_name() more predictable

As highlighted in #1817, `pkg_by_name()` could provide unpredictable
results, when using wildcards. As such, limited this method to only
returning package info for exact package name matches. In turn, change
`Plugin.is_installed()` to leverage `PackageManager.all_pkgs_by_name()`
which does explicitly support wildcards and returns information on _all_
matching packages, not just the last one found.

In so doing, clean up the `PackageManager` design to use a new
`packages` property for these lookups, and update the former usage of
`all_pkgs()` accordingly. Similarly, signal `get_pkg_list()` should be
private (in any sense that a python method can be) by renaming to
`_get_pkg_list()` and update the single Plugin (`etcd`) referencing this
method.

Closes: #1817

Signed-off-by: Jake Hunsaker <email address hidden>

3989. By Maros Kopec <email address hidden>

General data do main.fmf

Signed-off-by: Maros Kopec <email address hidden>

3988. By Maros Kopec <email address hidden>

Enable testing on Testing Farm

Using tmt/fmf enable testing on Testing Farm via Packit.
The executed tests are stable BeakrLib tests which were upstreamed for
this purpose.

Signed-off-by: Maros Kopec <email address hidden>

3987. By Jake Hunsaker <email address hidden>

[policies] Remove deadcode around runlevels

Removes the `runlevel_by_service()` methods from the redhat and suse
policies, as these methods are both outdated (by trying to leverage
`chkconfig`) and entirely unsued.

Further, removes the `LinuxPolicy.default_runlevel()` method as it is
similarly unused in sos.

Signed-off-by: Jake Hunsaker <email address hidden>

3986. By Jake Hunsaker <email address hidden>

[utilities] Switch locale to C.UTF-8

Changes the `LC_ALL` locale env var used for all command collections
from `C` to `C.UTF-8` which should provide safer/more reliable output
from non-English localizations. This is backed up by PEP-538:

    https://peps.python.org/pep-0538/

Closes: #2946

Signed-off-by: Jake Hunsaker <email address hidden>

3985. By Jake Hunsaker <email address hidden>

[clean] Refactor handling of symlink obfuscation

Previously, there was a small but not impossible situation for a race
condition within `clean`'s handling of symlinks where a symlink name
could be obfuscated differently than what the link's target could be
obfuscated too.

Fix this by handling symlinks separately than the rest of the archive,
like what we do for directory names. When obfuscating files, archives
will now skip over symlinks and yield file names for iteration, rather
than generating and returning full file lists. Once the obfuscation of
"real" files is complete, then separately iterate over symlinks. Since
the file obfuscation also includes file names, this means that link
targets are already known to the mappings and we eliminate the potential
race condition.

Closes: #2852

Signed-off-by: Jake Hunsaker <email address hidden>

3984. By Jake Hunsaker <email address hidden>

[sosnode] Properly pass `--namespaces` to nodes

The `namespaces` option was presented to `sos collect`, but was not
actually being passed to nodes.

Fix this, and gate the usage of the option to version 4.3, or the
relevant RHEL backport version like we do for `--container-runtime`.

Signed-off-by: Jake Hunsaker <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.