Merge lp:~soren/nova/support-newer-euca2ools into lp:~hudson-openstack/nova/trunk

Proposed by Soren Hansen
Status: Merged
Approved by: Soren Hansen
Approved revision: 928
Merged at revision: 933
Proposed branch: lp:~soren/nova/support-newer-euca2ools
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 25 lines (+6/-0)
1 file modified
tools/euca-get-ajax-console (+6/-0)
To merge this branch: bzr merge lp:~soren/nova/support-newer-euca2ools
Reviewer Review Type Date Requested Status
Todd Willey (community) Approve
Devin Carlen (community) Approve
Review via email: mp+55915@code.launchpad.net

Commit message

Make euca-get-ajax-console work with Euca2ools 1.3

To post a comment you must log in.
927. By Soren Hansen

Add euca2ools import

Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
Todd Willey (xtoddx) :
review: Approve
Revision history for this message
Todd Willey (xtoddx) wrote :

I didn't set ststus to approved since it wasn't linked to a bug report, and I'm not sure enough of the process after FF to know that approving wouldn't be faux pas. I'd like this in though, so change status as appropriate.

928. By Soren Hansen

Add bug reference.

Revision history for this message
Soren Hansen (soren) wrote :

> I didn't set ststus to approved since it wasn't linked to a bug report, and
> I'm not sure enough of the process after FF to know that approving wouldn't be
> faux pas. I'd like this in though, so change status as appropriate.

Good point. I forgot. Bug reference added, Approved button clicked. :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/euca-get-ajax-console'
2--- tools/euca-get-ajax-console 2011-03-18 13:56:05 +0000
3+++ tools/euca-get-ajax-console 2011-04-04 09:17:45 +0000
4@@ -35,6 +35,7 @@
5 import boto
6 import nova
7 from boto.ec2.connection import EC2Connection
8+import euca2ools
9 from euca2ools import Euca2ool, InstanceValidationError, Util
10
11 usage_string = """
12@@ -93,8 +94,13 @@
13 aws_secret_access_key, **kwargs)
14
15 # override boto's connect_ec2 method, so that we can use NovaEC2Connection
16+# (This is for Euca2ools 1.2)
17 boto.connect_ec2 = override_connect_ec2
18
19+# Override Euca2ools' EC2Connection class (which it gets from boto)
20+# (This is for Euca2ools 1.3)
21+euca2ools.EC2Connection = NovaEC2Connection
22+
23
24 def usage(status=1):
25 print usage_string