Merge lp:~soren/nova/sg-fallback-ipv6 into lp:~hudson-openstack/nova/trunk

[Soren Hansen]

Add missing fallback chain for ipv6.

[Koji Iida (iida-koji)]

Hi,

I had problem with this patch to run nova-compute.

root@usv601:/home/iida# /home/iida/nova/bin/nova-compute
2011-03-15 15:40:15,484 ERROR nova [-] in Service.create()
(nova): TRACE: Traceback (most recent call last):
(nova): TRACE: File "/home/iida/nova/nova/service.py", line 264, in serve
(nova): TRACE: services = [Service.create()]
(nova): TRACE: File "/home/iida/nova/nova/service.py", line 167, in create
(nova): TRACE: report_interval, periodic_interval)
(nova): TRACE: File "/home/iida/nova/nova/service.py", line 73, in __init__
(nova): TRACE: self.manager = manager_class(host=self.host, *args, **kwargs)
(nova): TRACE: File "/home/iida/nova/nova/compute/manager.py", line 118, in __init__
(nova): TRACE: self.driver = utils.import_object(compute_driver)
(nova): TRACE: File "/home/iida/nova/nova/utils.py", line 75, in import_object
(nova): TRACE: return cls()
(nova): TRACE: File "/home/iida/nova/nova/virt/connection.py", line 64, in get_connection
(nova): TRACE: conn = libvirt_conn.get_connection(read_only)
(nova): TRACE: File "/home/iida/nova/nova/virt/libvirt_conn.py", line 131, in get_connection
(nova): TRACE: return LibvirtConnection(read_only)
(nova): TRACE: File "/home/iida/nova/nova/virt/libvirt_conn.py", line 168, in __init__
(nova): TRACE: self.firewall_driver = fw_class(get_connection=self._get_connection)
(nova): TRACE: File "/home/iida/nova/nova/virt/libvirt_conn.py", line 1600, in __init__
(nova): TRACE: if FLAGS.use_ipv6:
(nova): TRACE: File "/home/iida/nova/nova/flags.py", line 139, in __getattr__
(nova): TRACE: val = gflags.FlagValues.__getattr__(self, name)
(nova): TRACE: File "/usr/lib/pymodules/python2.6/gflags.py", line 810, in __getattr__
(nova): TRACE: raise AttributeError(name)
(nova): TRACE: AttributeError: use_ipv6
(nova): TRACE:
2011-03-15 15:40:15,802 CRITICAL nova [-] use_ipv6
(nova): TRACE: Traceback (most recent call last):
(nova): TRACE: File "/home/iida/nova/bin/nova-compute", line 48, in <module>
(nova): TRACE: service.serve()
(nova): TRACE: File "/home/iida/nova/nova/service.py", line 264, in serve
(nova): TRACE: services = [Service.create()]
(nova): TRACE: File "/home/iida/nova/nova/service.py", line 167, in create
(nova): TRACE: report_interval, periodic_interval)
(nova): TRACE: File "/home/iida/nova/nova/service.py", line 73, in __init__
(nova): TRACE: self.manager = manager_class(host=self.host, *args, **kwargs)
(nova): TRACE: File "/home/iida/nova/nova/compute/manager.py", line 118, in __init__
(nova): TRACE: self.driver = utils.import_object(compute_driver)
(nova): TRACE: File "/home/iida/nova/nova/utils.py", line 75, in import_object
(nova): TRACE: return cls()
(nova): TRACE: File "/home/iida/nova/nova/virt/connection.py", line 64, in get_connection
(nova): TRACE: conn = libvirt_conn.get_connection(read_only)
(nova): TRACE: File "/home/iida/nova/nova/virt/libvirt_conn.py", line 131, in get_connection
(nova): TRACE: return LibvirtConnection(read_only)
(nova): TRACE: File "/home/iida/nova/nova/virt/libvirt_conn.py", line 168, in __init__
(nova): TRACE: self.firewall_driver = fw_c...

[Soren Hansen (soren)]

2011/3/15 Koji Iida <email address hidden>:
> Hi,
>
> I had problem with this patch to run nova-compute.

Ah, thanks for catching that. Fixed.

--
Soren Hansen        | http://linux2go.dk/
Ubuntu Developer    | http://www.ubuntu.com/
OpenStack Developer | http://www.openstack.org/

[lp:~soren/nova/sg-fallback-ipv6]

803. By Soren Hansen on 2011-03-15

Always put the ipv6 fallback in place. FLAGS.use_ipv6 does not exist yet when the firewall driver is instantiated and the iptables manager takes care not to fiddle with ipv6 if not enabled.

[Koji Iida (iida-koji)]

Thanks. It works well.

review: Approve

[Devin Carlen (devcamcar)]

lgtm

review: Approve

[Rick Harris (rconradharris)]

lgtm

review: Approve

=== modified file 'nova/virt/libvirt_conn.py'
--- nova/virt/libvirt_conn.py	2011-03-14 21:02:27 +0000
+++ nova/virt/libvirt_conn.py	2011-03-15 08:50:58 +0000
@@ -1597,6 +1597,8 @@
 
         self.iptables.ipv4['filter'].add_chain('sg-fallback')
         self.iptables.ipv4['filter'].add_rule('sg-fallback', '-j DROP')
+        self.iptables.ipv6['filter'].add_chain('sg-fallback')
+        self.iptables.ipv6['filter'].add_rule('sg-fallback', '-j DROP')
 
     def setup_basic_filtering(self, instance):
         """Use NWFilter from libvirt for this."""