OpenStack Compute (nova)

Merge lp:~soren/nova/run-tests-exit-code into lp:~hudson-openstack/nova/trunk

  1. run-tests-exit-code
  2. Merge into trunk
Proposed by Soren Hansen
Status: Merged
Approved by: Soren Hansen
Approved revision: 588
Merged at revision: 588
Proposed branch: lp:~soren/nova/run-tests-exit-code
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 23 lines (+2/-3)
2 files modified
Authors (+1/-0)
run_tests.sh (+1/-3)
To merge this branch: bzr merge lp:~soren/nova/run-tests-exit-code
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Approve
Jay Pipes (community) Approve
Review via email: mp+46842@code.launchpad.net

Commit message

Return non-zero if either unit tests or pep8 fails.

Description of the change

Um... Whoops. After I "fixed" run_tests.sh it no longer returns non-zero on failures.

To post a comment you must log in.
Revision history for this message
Jay Pipes (jaypipes) wrote :

ah, good fix.

review: Approve
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :
Download full text (21.1 KiB)

The attempt to merge lp:~soren/nova/run-tests-exit-code into lp:nova failed. Below is the output from the failed tests.

AdminAPITest
    test_admin_disabled ok
    test_admin_enabled ok
APITest
    test_exceptions_are_converted_to_faults ok
Test
    test_authorize_token ok
    test_authorize_user ok
    test_bad_token ok
    test_bad_user ok
    test_no_user ok
    test_token_expiry ok
TestLimiter
    test_authorize_token ok
TestFaults
    test_fault_parts ok
    test_raise ok
    test_retry_header ok
FlavorsTest
    test_get_flavor_by_id ok
    test_get_flavor_list ok
GlanceImageServiceTest
    test_create ok
    test_create_and_show_non_existing_image ok
    test_delete ok
    test_update ok
ImageControllerWithGlanceServiceTest
    test_get_image_details ok
    test_get_image_index ok
LocalImageServiceTest
    test_create ok
    test_create_and_show_non_existing_image ok
    test_delete ok
    test_update ok
LimiterTest
    test_minute ok
    test_one_per_period ok
    test_second ok
    test_users_get_separate_buckets ok
    test_we_can_go_indefinitely_if_we_spread_out_requests ok
WSGIAppProxyTest
    test_200 ok
    test_403 ok
    test_failure ok
WSGIAppTest
    test_escaping ok
    test_good_urls ok
    test_invalid_methods ok
    test_invalid_urls ok
    test_response_to_delays ok
ServersTest
    test_create_backup_schedules ok
    test_create_instance ok
    test_delete_backup_schedules ok
    test_delete_server_instance ok
    test_get_all_server_details ok
  ...

Revision history for this message
Vish Ishaya (vishvananda) wrote :

*chuckle* lgtm

review: Approve
Revision history for this message
Soren Hansen (soren) wrote :

Gah, someone actually managed to sneak something in that made it not pass. Thank goodness it's as simple as this :)

lp:~soren/nova/run-tests-exit-code updated
588. By Soren Hansen

Add Rob Kost to Authors.

Revision history for this message
Soren Hansen (soren) wrote :

<jedi mindtrick>This never happened.</jedi mindtrick>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Authors'
2--- Authors 2011-01-18 19:34:29 +0000
3+++ Authors 2011-01-19 22:36:16 +0000
4@@ -40,6 +40,7 @@
5 Paul Voccio <paul@openstack.org>
6 Rick Clark <rick@openstack.org>
7 Rick Harris <rconradharris@gmail.com>
8+Rob Kost <kost@isi.edu>
9 Ryan Lane <rlane@wikimedia.org>
10 Ryan Lucio <rlucio@internap.com>
11 Salvatore Orlando <salvatore.orlando@eu.citrix.com>
12
13=== modified file 'run_tests.sh'
14--- run_tests.sh 2011-01-19 09:50:54 +0000
15+++ run_tests.sh 2011-01-19 22:36:16 +0000
16@@ -71,6 +71,4 @@
17 fi
18 fi
19
20-run_tests
21-
22-pep8 --repeat --show-pep8 --show-source bin/* nova setup.py
23+run_tests && pep8 --repeat --show-pep8 --show-source bin/* nova setup.py || exit 1