Merge lp:~soren/nova/run-pep8-by-default into lp:~hudson-openstack/nova/trunk

[Soren Hansen]

Refactor run_tests.sh to allow us to run an extra command after the tests.

Run pep8 after unit tests in run_tests.sh.

Fix setup.py to be PEP-8 compliant.

I'm tired of having to run pep8 manually (or, more accurately, forget to run it altogether and have Hudson reject my patch). This patch adds pep8 to the end of run_tests.sh.

[Devin Carlen (devcamcar)]

lgtm

review: Approve

[Jay Pipes (jaypipes)]

lgtm, 2.

review: Approve

=== modified file 'run_tests.sh'
--- run_tests.sh	2010-12-28 21:43:35 +0000
+++ run_tests.sh	2011-01-19 10:06:09 +0000
@@ -31,46 +31,46 @@
 never_venv=0
 force=0
 noseargs=
-
+wrapper=""
 
 for arg in "$@"; do
   process_option $arg
 done
 
+function run_tests {
+  # Just run the test suites in current environment
+  ${wrapper} rm -f nova.sqlite
+  ${wrapper} $NOSETESTS 2> run_tests.err.log
+}
+
 NOSETESTS="python run_tests.py $noseargs"
 
-if [ $never_venv -eq 1 ]; then
-  # Just run the test suites in current environment
-  rm -f nova.sqlite
-  $NOSETESTS 2> run_tests.err.log
-  exit
-fi
-
-# Remove the virtual environment if --force used
-if [ $force -eq 1 ]; then
-  echo "Cleaning virtualenv..."
-  rm -rf ${venv}
-fi
-
-if [ -e ${venv} ]; then
-  ${with_venv} rm -f nova.sqlite
-  ${with_venv} $NOSETESTS 2> run_tests.err.log
-else  
-  if [ $always_venv -eq 1 ]; then
-    # Automatically install the virtualenv
-    python tools/install_venv.py
+if [ $never_venv -eq 0 ]
+then
+  # Remove the virtual environment if --force used
+  if [ $force -eq 1 ]; then
+    echo "Cleaning virtualenv..."
+    rm -rf ${venv}
+  fi
+  if [ -e ${venv} ]; then
+    wrapper="${with_venv}"
   else
-    echo -e "No virtual environment found...create one? (Y/n) \c"
-    read use_ve
-    if [ "x$use_ve" = "xY" -o "x$use_ve" = "x" -o "x$use_ve" = "xy" ]; then
-      # Install the virtualenv and run the test suite in it
+    if [ $always_venv -eq 1 ]; then
+      # Automatically install the virtualenv
       python tools/install_venv.py
+      wrapper="${with_venv}"
     else
-      rm -f nova.sqlite
-      $NOSETESTS 2> run_tests.err.log
-      exit
+      echo -e "No virtual environment found...create one? (Y/n) \c"
+      read use_ve
+      if [ "x$use_ve" = "xY" -o "x$use_ve" = "x" -o "x$use_ve" = "xy" ]; then
+        # Install the virtualenv and run the test suite in it
+        python tools/install_venv.py
+		wrapper=${with_venv}
+      fi
     fi
   fi
-  ${with_venv} rm -f nova.sqlite
-  ${with_venv} $NOSETESTS 2> run_tests.err.log
 fi
+
+run_tests
+
+pep8 --repeat --show-pep8 --show-source bin/* nova setup.py

=== modified file 'setup.py'
--- setup.py	2011-01-18 19:01:16 +0000
+++ setup.py	2011-01-19 10:06:09 +0000
@@ -41,6 +41,7 @@
             self.finalize_options()
             BuildDoc.run(self)
 
+
 class local_sdist(sdist):
     """Customized sdist hook - builds the ChangeLog file from VC first"""
 
@@ -57,17 +58,17 @@
                 changelog_file.write(str_dict_replace(changelog, mailmap))
         sdist.run(self)
 
-nova_cmdclass= { 'sdist': local_sdist,
-                 'build_sphinx' : local_BuildDoc }
+nova_cmdclass = {'sdist': local_sdist,
+                 'build_sphinx': local_BuildDoc}
 
 try:
-  from babel.messages import frontend as babel
-  nova_cmdclass['compile_catalog'] = babel.compile_catalog
-  nova_cmdclass['extract_messages'] = babel.extract_messages
-  nova_cmdclass['init_catalog'] = babel.init_catalog
-  nova_cmdclass['update_catalog'] = babel.update_catalog
+    from babel.messages import frontend as babel
+    nova_cmdclass['compile_catalog'] = babel.compile_catalog
+    nova_cmdclass['extract_messages'] = babel.extract_messages
+    nova_cmdclass['init_catalog'] = babel.init_catalog
+    nova_cmdclass['update_catalog'] = babel.update_catalog
 except:
-  pass
+    pass
 
 setup(name='nova',
       version=version.canonical_version_string(),