Merge lp:~soren/nova/lp720984 into lp:~hudson-openstack/nova/trunk

Proposed by Soren Hansen
Status: Merged
Approved by: Vish Ishaya
Approved revision: 696
Merged at revision: 697
Proposed branch: lp:~soren/nova/lp720984
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
nova/network/manager.py (+1/-1)
To merge this branch: bzr merge lp:~soren/nova/lp720984
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Approve
Devin Carlen (community) Approve
Review via email: mp+50236@code.launchpad.net

Commit message

Add **kwargs to VlanManager's create_networks so that optional args from other managers don't break.

Description of the change

"nova-manage create network" recently started passing a label kwarg to create_networks. VlanManager.create_networks has no such kwarg.

Add a **kwargs to VlanManager.create_networks to catch such optional args.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

lgtm

review: Approve
Revision history for this message
Jay Pipes (jaypipes) wrote :

hmm, this *really* should be picked up by unit tests...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/network/manager.py'
2--- nova/network/manager.py 2011-02-17 20:20:11 +0000
3+++ nova/network/manager.py 2011-02-17 21:51:56 +0000
4@@ -509,7 +509,7 @@
5 network_ref['bridge'])
6
7 def create_networks(self, context, cidr, num_networks, network_size,
8- cidr_v6, vlan_start, vpn_start):
9+ cidr_v6, vlan_start, vpn_start, **kwargs):
10 """Create networks based on parameters."""
11 # Check that num_networks + vlan_start is not > 4094, fixes lp708025
12 if num_networks + vlan_start > 4094: