Merge lp:~soren/nova/lp695157 into lp:~hudson-openstack/nova/trunk

Proposed by Soren Hansen
Status: Merged
Approved by: Todd Willey
Approved revision: 499
Merged at revision: 500
Proposed branch: lp:~soren/nova/lp695157
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
nova/wsgi.py (+1/-1)
To merge this branch: bzr merge lp:~soren/nova/lp695157
Reviewer Review Type Date Requested Status
Todd Willey (community) Approve
Vish Ishaya (community) Approve
Review via email: mp+44810@code.launchpad.net

Commit message

Address bug #695157 by using a blank request class and setting an empty request path.

This fixes the test suite in environments with webob >= 1.0 (e.g. Ubuntu Natty).

(Thanks for Greg Holt for the suggestion)

Description of the change

Address bug #695157 by using a blank request class and setting an empty request path.

This fixes the test suite in environments with webob >= 1.0 (e.g. Ubuntu Natty).

To post a comment you must log in.
Revision history for this message
Vish Ishaya (vishvananda) wrote :

lgtm

review: Approve
Revision history for this message
Todd Willey (xtoddx) :
review: Abstain
Revision history for this message
Todd Willey (xtoddx) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/wsgi.py'
2--- nova/wsgi.py 2010-11-22 22:28:28 +0000
3+++ nova/wsgi.py 2010-12-28 22:28:57 +0000
4@@ -270,7 +270,7 @@
5 needed to serialize a dictionary to that type.
6 """
7 self.metadata = metadata or {}
8- req = webob.Request(environ)
9+ req = webob.Request.blank('', environ)
10 suffix = req.path_info.split('.')[-1].lower()
11 if suffix == 'json':
12 self.handler = self._to_json