Merge lp:~soren/nova/eventlet-subprocess into lp:~hudson-openstack/nova/trunk

[Soren Hansen]

Use eventlet.green.subprocess instead of standard subprocess

Use eventlet.green.subprocess instead of standard subprocess

Eventlet's monkey patching causes the os.wait call in the standard
subprocess module to be non-blocking. This means that if it happens
to call self.wait on a Popen object that hasn't completely terminated
it'll be left as a zombie and its fd's are also leaked.

Oh, there's an eventlet side to this, too, so your eventlet will need patching.

The eventlet.green.subprocess module is b0rken if the os module is monkey patched (which it is in Nova).

Patched packages are available in the trunk PPA for Lucid and Maverick or in Ubuntu proper for Natty. The details (and the patch) are here

https://bitbucket.org/which_linden/eventlet/issue/77/subprocess-module-fails-if-os-module-is

[Jay Pipes (jaypipes)]

Well, that was easy :)

review: Approve

[Thierry Carrez (ttx)]

lgtm

review: Approve

[Vish Ishaya (vishvananda)]

lgtm

review: Approve

=== modified file 'nova/utils.py'
--- nova/utils.py	2011-02-09 19:18:48 +0000
+++ nova/utils.py	2011-02-14 20:14:59 +0000
@@ -25,7 +25,6 @@
 import json
 import os
 import random
-import subprocess
 import socket
 import struct
 import sys
@@ -36,6 +35,7 @@
 
 from eventlet import event
 from eventlet import greenthread
+from eventlet.green import subprocess
 
 from nova import exception
 from nova.exception import ProcessExecutionError